[Tapioca Add-on] Use gradual rollout API #2083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
tapioca-addon-feature-branch
branch
from
cc19ba0
to
3ce0a60
Compare
KaanOzkan
force-pushed
the
ko/prepare-branch
branch
from
63e435e
to
91a02da
Compare
KaanOzkan
force-pushed
the
ko/prepare-branch
branch
from
91a02da
to
d8f126d
Compare
vinistock
reviewed
Nov 22, 2024
| @@ -32,8 +32,7 @@ def initialize | |||
| sig { override.params(global_state: RubyLsp::GlobalState, outgoing_queue: Thread::Queue).void } | |||
| def activate(global_state, outgoing_queue) | |||
| @global_state = global_state | |||
| # TODO: Uncomment | |||
| # return unless @global_state.experimental_features | |||
| return unless @global_state.enabled_feature?(:tapioca_addon) | |||
There was a problem hiding this comment.
This is camel case because it comes from the JSON settings and we don't convert it to snake case.
Suggested change
| return unless @global_state.enabled_feature?(:tapioca_addon) | |
| return unless @global_state.enabled_feature?(:tapiocaAddon) |
| @@ -67,7 +66,7 @@ def version | |||
| sig { params(changes: T::Array[{ uri: String, type: Integer }]).void } | |||
| def workspace_did_change_watched_files(changes) | |||
| # TODO: Uncomment | |||
| # return unless T.must(@global_state).experimental_features | |||
| return unless T.must(@global_state).enabled_feature?(:tapioca_addon) | |||
There was a problem hiding this comment.
Need to also remove the TODO comment above.
Suggested change
| return unless T.must(@global_state).enabled_feature?(:tapioca_addon) | |
| return unless T.must(@global_state).enabled_feature?(:tapiocaAddon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implementation
Tests