Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS UI Extensions - Modal is not Full Screen as Expected #2414

Open
xqwtsz opened this issue Oct 14, 2024 · 4 comments
Open

POS UI Extensions - Modal is not Full Screen as Expected #2414

xqwtsz opened this issue Oct 14, 2024 · 4 comments
Labels
bug Something isn't working POS UI Extensions

Comments

@xqwtsz
Copy link

xqwtsz commented Oct 14, 2024

Please list the package(s) involved in the issue, and include the version you are using

"@shopify/ui-extensions": "2024.10.x",
"@shopify/ui-extensions-react": "2024.10.x"

Also

api_version = "2024-10"

in the shopify.extension.toml

Describe the bug

The Modal component that is with the target:

export default reactExtension('pos.home.modal.render', () => {
  return <Modal />
})

is rendering as a modal, and is NOT full screen as expected.

Steps to reproduce the behavior:

  1. Create a fresh POS UI Extension
  2. Change the api_version in the shopify.extension.toml to 2024-07
  3. Run npm run dev, everything is full screen, as expected.
  4. Change the api_version in the shopify.extension.toml to 2024-10
  5. Run npm run dev, modals look like modals and are not full screen.

Expected behavior

Expect the Modal to be full screen.

Screenshots

shopify.extension.toml - API Version - 2024-07 - Expected

Image

shopify.extension.toml - API Version - 2024-10 - Broken

Image

@xqwtsz xqwtsz added the bug Something isn't working label Oct 14, 2024
@xqwtsz
Copy link
Author

xqwtsz commented Oct 14, 2024

is just saw that this could be a feature and not a bug, depending on what you mean as Modal here

Image

Because, what is being rendered is NOT a Modal, its a fully featured extension, and it is benefiting greatly from being a full screen extension.

If you think this should be a feature at least provide the option to be full screen or windowed as a prop.

This kind of visually breaking changes with no way to circumvent them, and no backwards compatibility, is not cool. If I want to use the 2024-10 version now, I can't, because everything shrinks to %50 of its size for the whole extension horizontally......

@xqwtsz
Copy link
Author

xqwtsz commented Oct 31, 2024

@xqwtsz
Copy link
Author

xqwtsz commented Nov 11, 2024

@jamesvidler ???

@js-goupil
Copy link
Contributor

js-goupil commented Nov 22, 2024

@xqwtsz sorry for the late reply here, POS on iOS is now using sheet modals, it's an app wide design change. We did version this to 2024-10 and up, so on 2024-07 it would still be full screen, as we did not want to break existing extensions on older versions. But by updating to 2024-10, on iOS it will now be in a modal sheet. This is a POS wide change, and more in line with the iOS platform, not just a UI Extension change. You'll notice that on Android it's still full screen. Apologies for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working POS UI Extensions
Projects
None yet
Development

No branches or pull requests

3 participants