Sg/add in store pickup targets #1899
Draft
+118
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirgalleto
force-pushed
the
sg/add-in-store-pickup-targets
branch
from
cb57f92
to
e2106a9
Compare
sirgalleto
force-pushed
the
sg/add-in-store-pickup-targets
branch
from
e2106a9
to
41f54a8
Compare
|
Hey can you explain these targets as we don't have access to internal repo. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Closes https://github.com/Shopify/shopify/issues/493484
Draft until we determine if we want to ship the internal targets as well.
Background
Add new extension targets for In Store Pickup
admin.settings.in-store-pickup.renderadmin.settings.internal-in-store-pickup.renderadmin.settings.internal-in-store-pickup-location.renderadmin.settings.in-store-pickup-location.renderSolution
🎩
TBD
Checklist