-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional alt prop to POS image #2033
base: unstable
Are you sure you want to change the base?
Conversation
We detected some changes in |
src?: string; | ||
alt?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src?: string; | |
alt?: string; | |
/** | |
* The url of the image. | |
**/ | |
src?: string; | |
/** | |
* Alternative text for the image. | |
**/ | |
alt?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these just need comments!
@BrittaEvansFenton should we merge this? Or make the changes suggested? |
Background
Adds alt text as an optional prop
Follows what is expected: https://github.com/Shopify/ui-api-design/tree/main/components/Image
Questions
have I missed anything?
Solution
(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)
🎩
Checklist