V2 host scanning #140
Merged
V2 host scanning #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
chris124567
requested review from
n8maninger and
ChrisSchinnerl
and removed request for
n8maninger
n8maninger
reviewed
Nov 16, 2024
ChrisSchinnerl
approved these changes
Nov 19, 2024
explorer/scan.go
Outdated
| if !ok { | ||
| e.log.Debug("Host did not have any v2 siamux net addresses in its announcement, unable to scan", zap.Stringer("pk", host.PublicKey)) | ||
| continue | ||
| } else { |
There was a problem hiding this comment.
I think go vet is still complaining about this superfluous else.
There was a problem hiding this comment.
There is no else there in the last commit though... Github glitch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last of the v2 changes 😄