Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an example subsystem #18

Closed
IanTapply22 opened this issue Nov 12, 2023 · 4 comments · Fixed by #32
Closed

Create an example subsystem #18

IanTapply22 opened this issue Nov 12, 2023 · 4 comments · Fixed by #32
Assignees
@HoodieRocks
Labels
enhancement New feature or request medium priority This is a medium priority issue
Milestone
Porting 2023 Code

Comments

@IanTapply22
Copy link
Member

This should be a simple example of what a subsystem would look like and how it would integrate into the codebase while utilizing the proper tools.

Contributors, students, or mentors should be able to reference this example subsystem and truly understand how it works and how it meshes with the rest of the robot.
@IanTapply22 IanTapply22 added this to the Porting 2023 Code milestone Nov 12, 2023
@IanTapply22 IanTapply22 added medium priority This is a medium priority issue enhancement New feature or request labels Nov 12, 2023
@HoodieRocks HoodieRocks self-assigned this Nov 12, 2023
@IanTapply22 IanTapply22 mentioned this issue Nov 12, 2023
Closed
@IanTapply22
Copy link
Member Author

IanTapply22 commented Nov 12, 2023 •
edited
Loading

@colemacphail Should this be banded together and be classified as just porting the subsystems?

@colemacphail
Copy link
Member

you mean do this, #8, and other subsystems as 1 issue? I'd prefer leaving them separate personally. Could have a bunch of things as subtasks under 1 high level task of "port over subsystems" but either way they should be separate issues.

@HoodieRocks
Copy link
Contributor

HoodieRocks commented Nov 13, 2023 •
edited
Loading

Would #28 be good enough to be an "example subsystem" or was there some other quality or requirement needed?

@IanTapply22
Copy link
Member Author

Noe, I was thinking something like an arm, elevator, or an intake. As a student it would be VERY helpful to have something to reference that we'll most likely use for that year.

The odds we'll need an intake of some kind it very likely so I'd pick that.

@HoodieRocks HoodieRocks mentioned this issue Nov 22, 2023
Merged
8 tasks
@HoodieRocks HoodieRocks linked a pull request Nov 22, 2023 that will close this issue
Create example subsystem #32
Merged
8 tasks
colemacphail added a commit that referenced this issue Dec 2, 2023
@HoodieRocks @colemacphail
Create example subsystem (#32)
73ea7df 
# Description

This pull request adds an example subsystem for students to use to learn
about how subsystems and commands are used in a robot environment.

Fixes #18 

## Type of change

Please delete options that are not relevant.

- [X] New feature (non-breaking change which adds functionality)

# Checklist:

- [x] My code follows the style guidelines of this project
- [X] I have performed a self-review of my code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation, if any
- [X] My changes generate no new warnings
- [ ] I have performed tests that prove my fix is effective or that my
feature works, if necessary
- [ ] New and existing unit tests pass locally with my changes

---------

Co-authored-by: Ian Tapply <[email protected]>
Co-authored-by: Cole MacPhail <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HoodieRocks HoodieRocks

Labels
enhancement New feature or request medium priority This is a medium priority issue
Projects
None yet
Milestone
Porting 2023 Code
Development

Successfully merging a pull request may close this issue.

Create example subsystem Simbotics/Simbot-Base
3 participants
@colemacphail @HoodieRocks @IanTapply22