Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intake Subsystem to Robot Container #53

Closed
HoodieRocks opened this issue Dec 18, 2023 · 0 comments · Fixed by #60
Closed

Add Intake Subsystem to Robot Container #53

HoodieRocks opened this issue Dec 18, 2023 · 0 comments · Fixed by #60
Assignees
@HoodieRocks
Labels
enhancement New feature or request good first issue Good for newcomers high priority This is a high priority issue release critical This feature or bug needs to be merged before we release this project publicly
Milestone
Porting 2023 Code

Comments

@HoodieRocks
Copy link
Contributor

HoodieRocks commented Dec 18, 2023 •
edited
Loading

As of right now, the intake subsystem isn't in RobotContainer. It should definitely be in RobotContainer since intaking is pretty important.

You may also want to hook up some commands to triggers.

Time Estimate: 30 minutes
@HoodieRocks HoodieRocks added this to the Porting 2023 Code milestone Dec 18, 2023
@HoodieRocks HoodieRocks added enhancement New feature or request good first issue Good for newcomers high priority This is a high priority issue release critical This feature or bug needs to be merged before we release this project publicly labels Dec 18, 2023
@HoodieRocks HoodieRocks self-assigned this Jan 1, 2024
@HoodieRocks HoodieRocks mentioned this issue Jan 6, 2024
Merged
8 tasks
@IanTapply22 IanTapply22 linked a pull request Jan 6, 2024 that will close this issue
Add intake subsystem to RobotContainer.java #60
Merged
8 tasks
IanTapply22 pushed a commit that referenced this issue Jan 6, 2024
@HoodieRocks
Add intake subsystem to RobotContainer.java (#60)
7dc84b0 
# Description

This pull request adds the intake subsystem to the robot container,
allowing the intake to be used.

Scoring states have also been updated to be publicly accessible

Fixes #53 

## Type of change

Please delete options that are not relevant.

- [X] New feature (non-breaking change which adds functionality)

# Checklist:

- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation, if any
- [X] My changes generate no new warnings
- [X] I have performed tests that prove my fix is effective or that my
feature works, if necessary
- [X] New and existing unit tests pass locally with my changes

---------

Co-authored-by: github-actions <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HoodieRocks HoodieRocks

Labels
enhancement New feature or request good first issue Good for newcomers high priority This is a high priority issue release critical This feature or bug needs to be merged before we release this project publicly
Projects
None yet
Milestone
Porting 2023 Code
Development

Successfully merging a pull request may close this issue.

Add intake subsystem to RobotContainer.java Simbotics/Simbot-Base
2 participants
@HoodieRocks @IanTapply22