Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically close error snackbar #126

Open
thehamzarocks opened this issue Jul 5, 2020 · 4 comments
Open

Don't automatically close error snackbar #126

thehamzarocks opened this issue Jul 5, 2020 · 4 comments

Comments

@thehamzarocks
Copy link
Contributor

thehamzarocks commented Jul 5, 2020

Let the error snackbars persist for two reasons:

  1. The user gets more time to read them.
  2. In the case of polling for data, if an error occurs, we don't want it to repeatedly open and close which would be annoying.

(https://firebase.google.com/docs/functions/use-cases#notify_users_when_something_interesting_happens)

@maaverik
Copy link
Collaborator

maaverik commented Jul 6, 2020

Right ow, this is set to close in 5 seconds. Do you propose to increase the time or keep it persistent till a user closes it in certain cases?

@thehamzarocks
Copy link
Contributor Author

Hmm, we could keep it open so the user could see the error for as long as he wanted.
But in case things start working again, the open snackbar might be misleading

@daltonfury42
Copy link
Collaborator

Good point. Maybe we could get the both of both worlds... The SnackBar stays till the user dismisses it, but it automatically goes away if the failed network call had succeeded...

We would need a mechanism to then identify if that endpoint which failed before had succeed... should be doable. This is a nice problem to solve. :p

@thehamzarocks
Copy link
Contributor Author

Yes, this is the ideal way :)

@maaverik maaverik closed this as completed Sep 9, 2021
@maaverik maaverik reopened this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants