Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reuse the page layout across all pages #490

Open
daltonfury42 opened this issue Jan 26, 2021 · 9 comments
Open

Fix and reuse the page layout across all pages #490

daltonfury42 opened this issue Jan 26, 2021 · 9 comments

Comments

@daltonfury42
Copy link
Collaborator

We should standardise and reuse a common layout across all pages. We have four main pages: Home, Admin, Join and Status. The general layout of all the four pages are like this:

image

image

image

image

Currently each page has its own layout defined inside it. We should solve it at one place and reuse it across.

Open Question: What should be the approach? Flexbox vs Grid.

@mradenovic
Copy link
Contributor

With grid very complex layout can be achieved.
With flexbox the simplest approach would be to make all sections equal within the main content.

Large screen
Large
Medium screen
Medium
Small screen
Small

@daltonfury42
Copy link
Collaborator Author

We need the flex-wrap style in where sections automatically wrap properly so that the same page works without much issues on both desktop and mobile.

@mradenovic
Copy link
Contributor

We need the flex-wrap style in where sections automatically wrap properly so that the same page works without much issues on both desktop and mobile.

This is gonna be much easier to do once we are done with #492 and #516.

@prabureddy
Copy link
Contributor

prabureddy commented Feb 14, 2021

@daltonfury42 We already using Layout Component in all pages right if I'm not wrong? I don't see any issue here. I think I don't understand this issue. Can you please explain this a bit more.

@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Feb 14, 2021

We style the layout of each page independently. We should define some common css classes and reuse it across all pages, for the general page layout.

@mradenovic Do you have something else in mind?

@daltonfury42 daltonfury42 added the You Can Do This Will be accepted on priority label Feb 21, 2021
@shashank1503-cipher
Copy link

we can use flex-wrap

@NereidaRondon
Copy link

Hello, I would love the opportunity to work on converting the pages to CSS grid. Can I be assigned this issue? 😁

@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Oct 5, 2022 via email

@daltonfury42 daltonfury42 removed You Can Do This Will be accepted on priority hacktoberfest labels Oct 5, 2022
@nehagupta1504
Copy link

I would like to work on the pages to create a global layout which can be reused just like an HOC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants