Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page makes unnecessery fetch requests #545

Open
2 of 4 tasks
mradenovic opened this issue Feb 18, 2021 · 2 comments
Open
2 of 4 tasks

Home page makes unnecessery fetch requests #545

mradenovic opened this issue Feb 18, 2021 · 2 comments

Comments

@mradenovic
Copy link
Contributor

mradenovic commented Feb 18, 2021

For a single page app, there are too many fetch requests, e.g., ``home page will trigger getUserQueues almost every time it is rendered. Some of these issues are addressed in #544. I also identified a - couple of more places/events that trigger it:

  • On login - the app goes away and back to initiating page, causing a re-render. A possible solution is loginWithPopup.
  • On logout - app reloads origin page, causing another render. A possible solution is using different logout options.
  • Clicking Home in navigation. Currently, the home button is just an HTML anchor. A possible solution is using router history.
  • Clicking logo in the navbar, when current page is not home page. A possible solution TBD.
@maaverik
Copy link
Collaborator

maaverik commented Feb 28, 2021

Items 3 and 4 have been taken care of in #556

@daltonfury42
Copy link
Collaborator

daltonfury42 commented Mar 20, 2021

I'm not sure if we should use popups for login. It could break for someone using some popup blocker, too much hassle.

Can we be excused just for the case of login/logout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants