-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twilio Integration for client side SMS notification #643
Comments
@daltonfury42 i want to work on this feature. Pls let me know if u have any designs available for the same. |
@maaverik What is your thoughts on this one? This would allow the queue manager to set up and pay for SMS on his own, just that he will have to trust us with the credentials for twilio. @Burhan-Rashid sorry for the late replay. You can take it up if the proposal gets accepted and if you are still interested. |
It's a good idea. I just feel that we should also have an explicit disclaimer saying that we are saving the credentials, but not using it for anything else and users always have the option to delete it. |
Why should we have the disclaimer? 🤔 I feel having it might make someone overly cautious and then decide not to go ahead. |
In my view, if someone is going to add credentials, they're already pretty technically knowledgeable, so they would expect to know that at least we've thought about securing credentials, ours being an open-source project and all. |
Okay, makes sense. |
@maaverik @daltonfury42 I would like to take this up. Is it taken ? And one more question, is this eligible for hacktoberfest 2022 ? |
Hi @aswath-s-tw, this project is not being actively maintained anymore. Thanks anyway for offering to help! |
Feature: Let clients supply Twilio credentials to enable them to send SMS from their Twilio account.
Step 1:
In the queue settings, add two text boxes to enter their Account SID and Auth Token and a "Save Credentials" button.
Once the user clicks on save credentials, make a network call
Saving the credentials is a one time activity, on success or when the user navigates to settings again for the same or a different queue, in place of the above form, a "Clear Credentials" button should be displayed.
Clicking on the clear credentials button will make a
DELETE /me/sms?integration=twilio
backend call to delete the credentials.Step 2:
If credentials are saved at backend, a "Enable SMS" toggle will be activated, which the user can use to enable and pause notifications.
This should trigger a patch call to the backend:
Step 3:
The text was updated successfully, but these errors were encountered: