Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1]: Trailing slash in new theme path should be removed #8294

Open
asmith20002 opened this issue Jul 18, 2024 · 0 comments
Open

[2.1]: Trailing slash in new theme path should be removed #8294

asmith20002 opened this issue Jul 18, 2024 · 0 comments

Comments

@asmith20002
Copy link
Contributor

Basic Information

Apologies this is a minor bug. When submitting a new theme by specifying its folder path, if the path ends with "/", it gets saved in the database with that slash. The problem arises when SMF tries to minimize CSS files. For example the path to sprite images could get messed up.

Correct example (when there's no trailing "/")

div.sceditor-grip, .sceditor-button div {
  background-image: url(../../default/images/icons/editor_sprite.png);
  background-repeat: no-repeat;
  width: 16px;
  height: 16px;
}

Incorrect example (when the theme path ends with "/")

div.sceditor-grip, .sceditor-button div {
  background-image: url(../../../default/images/icons/editor_sprite.png);
  background-repeat: no-repeat;
  width: 16px;
  height: 16px;
}

It adds an extra "../" to the sprite path.

Steps to reproduce

Expected result

No response

Actual result

No response

Version/Git revision

2.1

Database Engine

All

Database Version

No response

PHP Version

No response

Logs

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant