[2.1] & [3.0]: Wrong alert message upon user activation

[sbulen]

Basic Information

This is a nit, but a pretty annoying one if you require admin approval & user activation. I get several of these erroneous alerts a day.

The alert when the new user activates their account uses the text: "xxxx just signed up (account requires activation)".

But they don't need activation... This was sent when they activated...

I don't know if this is a logic error (reusing message inappropriately) or a simple text error (text needs to change).

I've confirmed the same issue exists in 2.1 and 3.0.

Steps to reproduce

1. Config so new users require admin approval & email activation.
2. Test user signs up.
3. Admin approves.
4. Test user receives activation email
5. Test user clicks on link, gets brought to SMF logon screen, is informed account has been activated. (so far, so good, but...)
6. Admin receives an alert saying that the test user just signed up & the account needs activation...

Expected result

The alert should say that the user activated their account.

(Or, possibly, not send an alert at all???)

Actual result

AFTER user activation, an alert saying they need to be activated is sent:

Version/Git revision

3.0 alpha 2 & 2.1.4

Database Engine

All

Database Version

8.4

PHP Version

8.3.8

Logs

No response

Additional Information

No response