Code

Audit Final Round by Dylan Frendo#7

Code

Open

dillu24 wants to merge 197 commits intoempty-2SimplyStaking/agoric-cl-middleware:empty-2from full_reviewSimplyStaking/agoric-cl-middleware:full_reviewCopy head branch name to clipboard

+12,776

Commits

Commits on Nov 17, 2022

• First commit containing code for monitoring & middleware for testing

  jacquesvcritien

  committed
  e861edb

• Fixed accept oracle script + added grafana dashboard

  jacquesvcritien

  committed
  12d7d84

• Added oracle name to monitoring

  jacquesvcritien

  committed
  3b85427

Commits on Nov 18, 2022

• Added more docs regarding oracles.json file

  jacquesvcritien

  authored
  f5d6c2f

• Fixed typo

  jacquesvcritien

  authored
  8553f74

• Forced price submission for timer requests

  jacquesvcritien

  committed
  83c5e79

• Merge branch 'master' of https://github.com/jacquesvcritien/agoric-cl-middleware

  jacquesvcritien

  committed
  028daf5

Commits on Nov 22, 2022

• Fixed monitoring script

  jacquesvcritien

  committed
  5029f9d

Commits on Dec 5, 2022

• Cleaned code and added documentation

  jacquesvcritien

  committed
  0b530db

• Cleaned code & added documentation

  jacquesvcritien

  committed
  8d487c0

Commits on Dec 6, 2022

• Fixed small issues with new clean code

  jacquesvcritien

  committed
  22b5d3f

Commits on Jan 5, 2023

• Added the following:

  Show description for 03fc00f
  jacquesvcritien

  committed
  03fc00f

• Updated variable names

  jacquesvcritien

  committed
  60fa5df

• Fixed more variables

  jacquesvcritien

  committed
  9d93831

• Added some changes to the monitorinf script which reflect the latest changes in the smart contract

  jacquesvcritien

  committed
  5b7f94d

Commits on Jan 12, 2023

• changes to use numWantsSatisfied

  jacquesvcritien

  committed
  5076931

• Added last job submission time to state and changed to check errors

  jacquesvcritien

  committed
  7132e34

• Fixed monitoring & updated dashboard

  jacquesvcritien

  committed
  18c55c0

Commits on Jan 16, 2023

• Added script to provision wallet

  jacquesvcritien

  committed
  61b3f74

Commits on Jan 19, 2023

• Optimising middleware and monitoring script

  jacquesvcritien

  committed
  981cce9

• Reducing gas consumption

  jacquesvcritien

  committed
  ce1b7e4

Commits on Jan 20, 2023

• Avoiding old round submissions

  jacquesvcritien

  committed
  1b71181

• Added reply to the CL node without waiting for the price push

  jacquesvcritien

  committed
  dcde3d2

• Making price pushes more efficient

  jacquesvcritien

  committed
  b94e758

Commits on Jan 21, 2023

• Increasing pushing interval to 10m

  jacquesvcritien

  committed
  36ee050

• Fixing middleware with issue for startedAt

  jacquesvcritien

  committed
  8daa778

• Fixing issue with middleware

  jacquesvcritien

  committed
  b4d69e9

Commits on Jan 22, 2023

• Removed unwanted files

  jacquesvcritien

  committed
  3edd26e

Commits on Jan 24, 2023

• Readd monitor scrpi

  jacquesvcritien

  committed
  02c4e5f

• Change folder name

  jacquesvcritien

  committed
  7f006bf

• Update documentation

  jacquesvcritien

  committed
  353b3a9

• Updated documentation

  jacquesvcritien

  committed
  f90f087

• Removed unwanted line

  jacquesvcritien

  committed
  3a956f9

• Removed unused function

  jacquesvcritien

  committed
  4e1f7ec

• Updated documentation

  jacquesvcritien

  committed
  f4e3f2d

• Documentation update

  jacquesvcritien

  committed
  a1930f0

Commits on Jan 25, 2023

• Updated documentation

  jacquesvcritien

  committed
  0c2c891

• Cleaning code

  jacquesvcritien

  committed
  5d1c4cc

Commits on Jan 26, 2023

• Small update to pointer

  jacquesvcritien

  committed
  5776fb4

• Getting rid of exiters

  jacquesvcritien

  committed
  d4e1c20

• Updated documentation to reflect last commit's changes

  jacquesvcritien

  committed
  8a3670c

• Removing global env vars for poll, push intervals, decimal places and perc threshold

  jacquesvcritien

  committed
  2e2d3e0

• Fixing entry script for monitoring

  jacquesvcritien

  committed
  3ca7280

• Fixed path for feeds file

  jacquesvcritien

  committed
  1983889

• Updated documentation

  jacquesvcritien

  committed
  aa3e56b

Commits on Jan 27, 2023

• Updating accept oracle invitation script

  jacquesvcritien

  committed
  80bc727

• Updating middleware to avoid using offers file

  jacquesvcritien

  committed
  9d1a956

• Updated documentation to remove OFFERS_FILE

  jacquesvcritien

  committed
  7ba566f

• Updated toc

  jacquesvcritien

  committed
  805c217

Commits on Jan 28, 2023

• Increasing poll interval to 3m

  jacquesvcritien

  committed
  f635a39

Commits on Feb 6, 2023

• Fixing startup issue

  jacquesvcritien

  committed
  d18f7ee

• Added price update condition

  jacquesvcritien

  committed
  6a7d5a0

• Trying to fix middlewre offers issue

  jacquesvcritien

  committed
  ac87a0f

• Added change for offers to monitor

  jacquesvcritien

  committed
  6f9fc0f

• Fixing issue with monitoring script

  jacquesvcritien

  committed
  627388b

• Fixing issue with monitoring script

  jacquesvcritien

  committed
  fa27d53

Commits on Feb 14, 2023

• Fixed some typos

  jacquesvcritien

  committed
  9e3c0d6

Commits on Feb 15, 2023

• Merge branch 'master' into full_review

  

  dillu24

  committed
  57e20c2

Commits on Feb 16, 2023

• Added tests, fixed small issue with getOffers, updated docs and added helper function for vstorage query

  jacquesvcritien

  committed
  ca6a76d

• Updated modules for tests

  jacquesvcritien

  committed
  c4427c2

• Merge pull request #2 from jacquesvcritien/master

  Show description for 91b72a3
  jacquesvcritien

  authored
  91b72a3

Commits on Feb 21, 2023

• Moved to sqllite DB from JSON state file + Updated docs, tests.

  jacquesvcritien

  committed
  47346bd

• Fixed typos and added line width

  jacquesvcritien

  committed
  e594b39

• Added builds to docker-compose file

  jacquesvcritien

  committed
  195cc08

Commits on Feb 22, 2023

• Updated read me for docker-compose change

  jacquesvcritien

  committed
  786f629

• Merge pull request #3 from jacquesvcritien/master

  Show description for 276d72d
  jacquesvcritien

  authored
  276d72d

• Adding 80 character line limit

  jacquesvcritien

  committed
  e7d6c89

• Removed .DS_Store and added it to gitignore

  jacquesvcritien

  committed
  707949b

• Refactored code and split functions into helper functions

  jacquesvcritien

  committed
  75621d3

• Removed useless print

  jacquesvcritien

  committed
  a6326b8

• Fixed documentation typos and grammatical errors

  jacquesvcritien

  committed
  cd76729

• Changed to docker-compose commands

  jacquesvcritien

  committed
  eedaed1

• Updated docs for consistency

  jacquesvcritien

  committed
  b0e6e4b

• Rewording in docs

  jacquesvcritien

  committed
  d618962

• Moved feeds.json to config folder

  jacquesvcritien

  committed
  2220ec8

• Moved feeds file to config folder

  jacquesvcritien

  committed
  dcfe378

• Fixed small typo

  jacquesvcritien

  committed
  978a034

• Moved imports before mocking

  jacquesvcritien

  committed
  22a2462

• Merge pull request #4 from jacquesvcritien/master

  Show description for 2783150
  jacquesvcritien

  authored
  2783150

• Added all env vars to docker-compose and rename feeds.json to feeds-config.json

  jacquesvcritien

  committed
  ef14bde

• Updated description in package.json

  jacquesvcritien

  committed
  c6b21b3

• Lowered job request timeout to 5s

  jacquesvcritien

  committed
  0a0d06b

• Changed failover price to -1

  jacquesvcritien

  committed
  aa7bbc4

• Removed extra comment

  jacquesvcritien

  committed
  d342e64

• Removed .vscode from git

  jacquesvcritien

  committed
  131718b

• Fixed for line width

  jacquesvcritien

  committed
  670ac02

• Formatted tests for 80 line width

  jacquesvcritien

  committed
  2a7bc45

• Documentation updates

  jacquesvcritien

  committed
  d85360c

• Changed != to !== and == to ===

  jacquesvcritien

  committed
  ad4d3cb

• Cleaned util code

  jacquesvcritien

  committed
  5811039

• Changed all var to let

  jacquesvcritien

  committed
  d2ad409

• Changing lastVisited to -1 to avoid possible issue with id 0

  jacquesvcritien

  committed
  e6e00fe

• Cleaned code for line width

  jacquesvcritien

  committed
  8db3abf

• Updated comments to include space and starting letter as capital

  jacquesvcritien

  committed
  c97d578

• Merge pull request #5 from jacquesvcritien/master

  Show description for 4d59ffa
  jacquesvcritien

  authored
  4d59ffa

• Removed extra code

  jacquesvcritien

  committed
  87abd4f

Commits on Feb 23, 2023

• Added a fix to the monitoring script

  jacquesvcritien

  committed
  1ba5446

• Fixed some indentation

  jacquesvcritien

  committed
  f9432cb

• Fixed docker service for monitor

  jacquesvcritien

  committed
  b428c13

• Removing counter and using history.length

  jacquesvcritien

  committed
  138c431

• Fixed typos in docs

  jacquesvcritien

  committed
  f060346

• Fixed else if indentation

  jacquesvcritien

  committed
  07cae21

• Changed wording in docs

  jacquesvcritien

  committed
  e3ae942

• Fixed example in docs

  jacquesvcritien

  committed
  8a77991

• Combined condition

  jacquesvcritien

  committed
  e4c3b49

• Updated comment

  jacquesvcritien

  committed
  71bb622

• Separated function which checks whether a price push update should be made and added type casting for all feeds config values

  jacquesvcritien

  committed
  e9a33da

• Fixing issue with new utils function

  jacquesvcritien

  committed
  1881ba6

• Split condition

  jacquesvcritien

  committed
  e16864f

• Broke down condition

  jacquesvcritien

  committed
  6248090

• Removing extra line setting the id for the offer

  jacquesvcritien

  committed
  a18a2ee

• Removed extra line in monitoring

  jacquesvcritien

  committed
  a534c54

• Removed any ts comments

  jacquesvcritien

  committed
  eaa7011

• Removed ts comments part 2

  jacquesvcritien

  committed
  e9bf66d

• Changed to foreach

  jacquesvcritien

  committed
  3772c9e

• Fixed function comment

  jacquesvcritien

  committed
  de8807b

• Fixed docs

  jacquesvcritien

  committed
  e91055d

• Fixed comment

  jacquesvcritien

  committed
  cf641ec

• Calling getOraclesInvitations() on every interval in monitor

  jacquesvcritien

  committed
  4fc5833

• Removed extra print

  jacquesvcritien

  committed
  327efae

• Fixed some formatting in monitor

  jacquesvcritien

  committed
  9c07061

• Changed to oracleLastEpoch for consistency

  jacquesvcritien

  committed
  488fb2f

• Fixed test comment to match standard

  jacquesvcritien

  committed
  07a9328

• Reverted offers foreach

  jacquesvcritien

  committed
  7b9b88c

• Refactored controller and bridge

  jacquesvcritien

  committed
  6bd4755

• Fixed package name

  jacquesvcritien

  committed
  9972147

• Fixed condition for /adapter

  jacquesvcritien

  committed
  9d49fe1

• Added some more comments

  jacquesvcritien

  committed
  2a70a72

• Updated spacing

  jacquesvcritien

  committed
  5408f18

• Updated more spacing

  jacquesvcritien

  committed
  00e2e01

• Fixed formatting

  jacquesvcritien

  committed
  3c8d4af

• Fixed comments indentation

  jacquesvcritien

  committed
  9f027c8

• Added more spacing

  jacquesvcritien

  committed
  dd01cbd

• Fixed line limit for comment

  jacquesvcritien

  committed
  1068142

• Added space in monitor

  jacquesvcritien

  committed
  bab17ac

• Cleaned line in monitor

  jacquesvcritien

  committed
  54132c2

• Updated docs

  jacquesvcritien

  committed
  66a78fb

• Removed two unused scripts

  jacquesvcritien

  committed
  4c5dd9c

• Added link to setup-docs

  jacquesvcritien

  committed
  707addb

• Updated docs

  jacquesvcritien

  committed
  70bc917

• Fixing comment

  jacquesvcritien

  committed
  822e961

• Added examples for feed and jobName

  jacquesvcritien

  committed
  42dc406

• Added vstorage explanation

  jacquesvcritien

  committed
  cd710e1

• Fixed console print

  jacquesvcritien

  committed
  653447f

• Creating a class for the middleware env vars

  jacquesvcritien

  committed
  78b48d4

• Fixing middlewareEnv

  jacquesvcritien

  committed
  82aea45

• Fixing env var classes

  jacquesvcritien

  committed
  47af31f

• Added block interval to middleware env vars

  jacquesvcritien

  committed
  6e5ed8b

• Added checks for numbers

  jacquesvcritien

  committed
  fdffab7

• Changed != to !== in env var classes

  jacquesvcritien

  committed
  3efa2ed

• Fixed comment in monitor

  jacquesvcritien

  committed
  670217e

• Removing FEEDS_FILE from an env var

  jacquesvcritien

  committed
  4ac2d76

Commits on Feb 24, 2023

• Wrapped endpoints in try catches

  jacquesvcritien

  committed
  2c22ec9

• Moved to winston logger

  jacquesvcritien

  committed
  6903cb6

• Changed log commas to +

  jacquesvcritien

  committed
  5e00308

• Removed extra JSON parsing

  jacquesvcritien

  committed
  e4354ea

• Adding validation for feed invitation

  jacquesvcritien

  committed
  2bc26d5

• Added try catches for capdata parsing

  jacquesvcritien

  committed
  a3baaa8

• Wrapped db functions in try catches

  jacquesvcritien

  committed
  2c23f76

• Added check for jobname

  jacquesvcritien

  committed
  0634fe7

• Removed catches from updateTable

  jacquesvcritien

  committed
  049494e

• Removed extra catches

  jacquesvcritien

  committed
  ad863b5

• Changed name for uppercase to temp

  jacquesvcritien

  committed
  0e14b95

• Renamed Env class files

  jacquesvcritien

  committed
  0d858dd

• Fixed small thing in test

  jacquesvcritien

  committed
  5467000

• Added oracle parameter to getOraclesInvitations

  jacquesvcritien

  committed
  a9027ca

• Removed unused import

  jacquesvcritien

  committed
  df3e68e

• Fixed issue related to getOraclesInvitations

  jacquesvcritien

  committed
  ec0c342

• Added some formatting changes to chain.js

  jacquesvcritien

  committed
  9899126

• Changes to modularise the monitoring script

  jacquesvcritien

  committed
  bafa574

• Created config classes

  jacquesvcritien

  committed
  3a916f2

• Fixed small import

  jacquesvcritien

  committed
  56be0c2

• Imported feeds config

  jacquesvcritien

  committed
  a292d52

• Fixing issue with feedsconfig

  jacquesvcritien

  committed
  bc2d6ee

• Fixed another issue with feeds

  jacquesvcritien

  committed
  f622fd6

• Added db migrations

  jacquesvcritien

  committed
  c24989f

• Fixed second migration

  jacquesvcritien

  committed
  00e4382

• Fixed db functions to match new package

  jacquesvcritien

  committed
  c683c7a

• Updated second migration

  jacquesvcritien

  committed
  40f68e5

• Changed round details to a class

  jacquesvcritien

  committed
  de65db1

Commits on Feb 25, 2023

• Merge pull request #6 from jacquesvcritien/master

  Show description for 5166612
  jacquesvcritien

  authored
  5166612

Commits on Feb 27, 2023

• Removed unused imports

  jacquesvcritien

  committed
  0f2d4ec

• Changed env classes to singletons + removed some unused imports

  jacquesvcritien

  committed
  a64393c

• Fixing import

  jacquesvcritien

  committed
  dfbb9c0

• Importing monitorEnvInstance for monitor.js

  jacquesvcritien

  committed
  b95e541

• Updated .env sample

  jacquesvcritien

  committed
  ec2df2c

• Changed filenames

  jacquesvcritien

  committed
  317321c

• Updated credentials filename

  jacquesvcritien

  committed
  5875788

• Reverting env sample changes

  jacquesvcritien

  committed
  e2df618

• Cosmetic changes

  jacquesvcritien

  committed
  268caad

• More cosmetic changes

  jacquesvcritien

  committed
  9379c56

• More minor fixes

  jacquesvcritien

  committed
  29244ce

• Added poll_interval to docker-compose, added check for invitations value and enhanced comments

  jacquesvcritien

  committed
  672f0f1

• Merge pull request #8 from jacquesvcritien/master

  Show description for c332c3e
  jacquesvcritien

  authored
  c332c3e

• Switched to template strings

  jacquesvcritien

  committed
  eeb7e3d

• Fixing typo

  jacquesvcritien

  committed
  0cff0c4

Commits on Feb 28, 2023

• Merge pull request #9 from jacquesvcritien/master

  Show description for d67b4f1
  jacquesvcritien

  authored
  d67b4f1