From 1c84f9e8dcd71cf833cd792fe7c99c2098dfa200 Mon Sep 17 00:00:00 2001 From: Addy Pathania Date: Fri, 15 Sep 2023 14:57:18 -0400 Subject: [PATCH 1/2] change sitemap service pageSize, serialize getStaticPaths --- .../services/base-graphql-sitemap-service.ts | 37 ++++++++++--------- .../services/graphql-sitemap-service.test.ts | 3 +- 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts b/packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts index 61b1fec4fe..089b901f7c 100644 --- a/packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts +++ b/packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts @@ -27,7 +27,7 @@ query ${usesPersonalize ? 'PersonalizeSitemapQuery' : 'DefaultSitemapQuery'}( $language: String! $includedPaths: [String] $excludedPaths: [String] - $pageSize: Int = 10 + $pageSize: Int = 100 $after: String ) { site { @@ -86,7 +86,7 @@ interface SiteRouteQueryVariables { /** common variable for all GraphQL queries * it will be used for every type of query to regulate result batch size * Optional. How many result items to fetch in each GraphQL call. This is needed for pagination. - * @default 10 + * @default 100 */ pageSize?: number; } @@ -223,21 +223,24 @@ export abstract class BaseGraphQLSitemapService { formatStaticPath: (path: string[], language: string) => StaticPath ) { const paths = new Array(); - await Promise.all( - languages.map(async (language) => { - if (language === '') { - throw new RangeError(languageEmptyError); - } - debug.sitemap('fetching sitemap data for %s %s', language, siteName); - const results = await this.fetchLanguageSitePaths(language, siteName); - const transformedPaths = await this.transformLanguageSitePaths( - results, - formatStaticPath, - language - ); - paths.push(...transformedPaths); - }) - ); + + for (const language of languages) { + if (language === '') { + throw new RangeError(languageEmptyError); + } + + debug.sitemap('fetching sitemap data for %s %s', language, siteName); + + const results = await this.fetchLanguageSitePaths(language, siteName); + const transformedPaths = await this.transformLanguageSitePaths( + results, + formatStaticPath, + language + ); + + paths.push(...transformedPaths); + } + return paths; } diff --git a/packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts b/packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts index 2ec30b73f8..aa12c658f9 100644 --- a/packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts +++ b/packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts @@ -439,7 +439,8 @@ describe('GraphQLSitemapService', () => { .post( '/', (body) => - body.query.indexOf('$pageSize: Int = 10') > 0 && body.variables.pageSize === undefined + body.query.indexOf('$pageSize: Int = 100') > 0 && + body.variables.pageSize === undefined ) .reply(200, sitemapDefaultQueryResult); From 85ab6b94f28ef02cb670c2e15b21c3f19f0947d0 Mon Sep 17 00:00:00 2001 From: Addy Pathania Date: Fri, 15 Sep 2023 15:03:45 -0400 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 62892ef860..747cd31145 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ Our versioning strategy is as follows: * `[sitecore-jss-react]` Fetch Data for FEaaS Components as part of Component SSR/SSG ([#1586](https://github.com/Sitecore/jss/pull/1590)) * `[sitecore-jss-dev-tools]` `[templates/nextjs]` `[templates/react]` Introduce "components" configuration for ComponentBuilder ([#1598](https://github.com/Sitecore/jss/pull/1598)) * `[sitecore-jss-react]` `[sitecore-jss-nextjs]` Component level data fetching(SSR/SSG) for BYOC ([#1610](https://github.com/Sitecore/jss/pull/1610)) +* `[sitecore-jss-nextjs]` Reduce the amount of Edge API calls during fetch getStaticPaths ([#1612](https://github.com/Sitecore/jss/pull/1612)) ### 🧹 Chores