From 8278bf1ef3fd2b47f436dc9defece610e576d3d5 Mon Sep 17 00:00:00 2001 From: Addy Pathania Date: Mon, 8 Jan 2024 12:57:43 -0500 Subject: [PATCH 1/2] fix webpack config --- .../nextjs-xmcloud/src/lib/next-config/plugins/feaas.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/next-config/plugins/feaas.js b/packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/next-config/plugins/feaas.js index 6731497e0a..d79aeadee4 100644 --- a/packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/next-config/plugins/feaas.js +++ b/packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/next-config/plugins/feaas.js @@ -13,8 +13,8 @@ const feaasPlugin = (nextConfig = {}) => { '@sitecore-feaas/clientside/react': 'commonjs @sitecore-feaas/clientside/react', '@sitecore/byoc': 'commonjs @sitecore/byoc', '@sitecore/byoc/react': 'commonjs @sitecore/byoc/react', - ...config.externals, }, + ...config.externals, ]; } From 57dc2a3ce1e6aadef6c510f29ef83c8de51bae8e Mon Sep 17 00:00:00 2001 From: Addy Pathania Date: Mon, 8 Jan 2024 13:01:06 -0500 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index acef4148ff..017cbe37bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,7 +30,7 @@ Our versioning strategy is as follows: * `[sitecore-jss-react]` `[templates/nextjs-xmcloud]` Ensure FEAAS and BYOC components can correctly use item datasources ([#1694](https://github.com/Sitecore/jss/pull/1694)) * `[sitecore-jss-nextjs]` Fix loop error in redirect middleware when the pattern of redirect has default locale. ([#1696](https://github.com/Sitecore/jss/pull/1696)) * `[templates/nextjs-sxa]` Fix feature `show Grid column` in Experience Editor. ([#1704](https://github.com/Sitecore/jss/pull/1704)) -* `[templates/nextjs-xmcloud]` Fix double registration of BYOC components ([#1707](https://github.com/Sitecore/jss/pull/1707)) +* `[templates/nextjs-xmcloud]` Fix double registration of BYOC components ([#1707](https://github.com/Sitecore/jss/pull/1707)) ([#1709](https://github.com/Sitecore/jss/pull/1709)) ### 🛠 Breaking Changes