Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should also run when consul_acl & nomad_acl is true #119

Open
1 of 3 tasks
claesgill opened this issue Apr 28, 2021 · 0 comments
Open
1 of 3 tasks

Tests should also run when consul_acl & nomad_acl is true #119

claesgill opened this issue Apr 28, 2021 · 0 comments

Comments

@claesgill
Copy link
Contributor

Current behavior

Tests in 05_trino_create_tables.yml are skipped if consul_acl and nomad_acl is set.

Tests are skipped because the tests fails (unknown reason).
Tests failing are validation of CSV,JSON etc.

Expected behavior

All tests should run regardless.

How to reproduce?

  • In .env set consul_acl and nomad_acl to true (might need token/mor variables)
  • make test-standalone see that test are skipped.

Suggestion(s)/solution(s) [Optional]

Should not need this in the tests:
when: not lookup('env', 'nomad_acl') | bool and not lookup('env', 'consul_acl') | bool

Checklist (after created issue)

  • Added label(s)
  • Added to project
  • Added to milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant