Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprColorOf doesn't work and freezes the server #5260

Open
1 task done
GStudiosX2 opened this issue Dec 22, 2022 · 6 comments
Open
1 task done

ExprColorOf doesn't work and freezes the server #5260

GStudiosX2 opened this issue Dec 22, 2022 · 6 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@GStudiosX2
Copy link

GStudiosX2 commented Dec 22, 2022

Skript/Server Version

[20:26:33 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[20:26:33 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[20:26:33 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[20:26:33 INFO]: [Skript] Server Version: git-Paper-348 (MC: 1.19.3)
[20:26:33 INFO]: [Skript] Skript Version: 2.6.4
[20:26:33 INFO]: [Skript] Installed Skript Addons: 
[20:26:33 INFO]: [Skript]  - skript-reflect v2.3 (https://github.com/TPGamesNL/skript-reflect)
[20:26:33 INFO]: [Skript]  - SkBee v2.5.4 (https://github.com/ShaneBeee/SkBee)
[20:26:33 INFO]: [Skript] Installed dependencies: 
[20:26:33 INFO]: [Skript]  - Vault v1.7.3-b131

Bug Description

ExprColorOf doesn't work and also freezes the server
all I ran "!send color of player's tool"
I don't know if its effect commands only

Expected Behavior

for it to print the color of the item im holding

Steps to Reproduce

  1. run the effect command "!send color of player's tool"
  2. doesn't work and the console gets spammed and no one can join anymore and it requires a full restart

Errors or Screenshots

https://gist.github.com/GStudiosX2/f76fb0c0db65f322e2b5f272dbe5c67c

Other

nope

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@GStudiosX2 GStudiosX2 changed the title ExprColorOf doesn't work ExprColorOf doesn't work and freezes the server Dec 22, 2022
@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Dec 23, 2022

I can't replicate crashing the server, but I can replicate the syntax not returning anything when holding a leather chestplate coloured lime and seems to have been broken before 2.6.3.

My guess is because there is no support for ItemStack in the syntax as ItemType used to be what was returned from the player's tool, and the converter is just not working for some reason, crashing your server, but just not working in general for me.

@TheLimeGlass TheLimeGlass added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Dec 23, 2022
@GStudiosX2
Copy link
Author

GStudiosX2 commented Dec 23, 2022

I can't replicate crashing the server, but I can replicate the syntax not returning anything when holding a leather chestplate coloured lime and seems to have been broken before 2.6.3.

My guess is because there is no support for ItemStack in the syntax as ItemType used to be what was returned from the player's tool, and the converter is just not working for some reason, crashing your server, but just not working in general for me.

I'm using like 2 versions out of date build of paper 1.19.3 I don't know if skript supports 1.19.3 or not yet especially because I'm using 2.6.4 which pretty sure got released before 1.19.3

idk but I think the where it returns nothing should still get fixed xd

I have no idea why it's crashing it only really crashed when I run it twice I think I can't really remember might of been when I ran it once though I can share the config.sk in a bit if you need it.

And I probably could record a video later of the server crashingish it's not really crashing it just gets frozen 😅

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Dec 23, 2022

I just tested with the latest Paper build of 1.19.3 and Skript 2.6.4.

What item are you holding and can you provide details to attain it, if it has NBT etc.

@GStudiosX2
Copy link
Author

I just tested with the latest Paper build of 1.19.3 and Skript 2.6.4.

What item are you holding and can you provide details to attain it, if it has NBT etc.

I can't really remember but it was a dyed leather boots

@AyhamAl-Ali
Copy link
Member

ExprColorOf doesn't work with leather armors yet, this PR adds this support #4335

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). and removed bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Dec 24, 2022
@GStudiosX2
Copy link
Author

GStudiosX2 commented Dec 24, 2022

ExprColorOf doesn't work with leather armors yet, this PR adds this support #4335

oh really ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

3 participants