Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operators Reloading bug #7103

Open
1 task done
EquipableMC opened this issue Sep 21, 2024 · 1 comment
Open
1 task done

Operators Reloading bug #7103

EquipableMC opened this issue Sep 21, 2024 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Comments

@EquipableMC
Copy link
Contributor

Skript/Server Version

[12:16:07 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[12:16:07 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[12:16:07 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[12:16:07 INFO]: [Skript] Server Version: 1.21.1-77-4ff58c4 (MC: 1.21.1)
[12:16:07 INFO]: [Skript] Skript Version: 2.9.2 (selfbuilt-unknown)
[12:16:07 INFO]: [Skript] Installed Skript Addons: 
[12:16:07 INFO]: [Skript]  - DiSky v4.19.0
[12:16:07 INFO]: [Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[12:16:07 INFO]: [Skript] Installed dependencies: None

Bug Description

Ever since #6780 was merged, it has caused messages to be bugged and not formatted properly. Seems to be an issue with redirectingloghandler.

Expected Behavior

The messages to be formatted properly.

Steps to Reproduce

use a skript jar from dev/feature, reload a skript, boom broken messages
(optional) use a skript jar from dev/feature, reload a skript, make sure there is an error or 2 or however many you want, boom even more broken messages

Errors or Screenshots

No Errors + Ingame
image
Errors + Ingame
image
No Errors + Console
image
Errors + Console
image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@AyhamAl-Ali
Copy link
Member

  • First, because it's Level.INFO it's ignored by LogEntry#toFormattedString(...) (link)
  • Second, it's now using LogHandler#log which doesn't support chat color, before it was using Skript#info and Skript#error which uses Utils#replaceEnglishChatStyles(...)

@AyhamAl-Ali AyhamAl-Ali added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Sep 21, 2024
@APickledWalrus APickledWalrus self-assigned this Sep 25, 2024
@sovdeeth sovdeeth added the PR available Issues which have a yet-to-be merged PR resolving it label Oct 13, 2024
@sovdeeth sovdeeth added completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

No branches or pull requests

4 participants