-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExprPlayerProtocolVersion #4569
Merged
TPGamesNL
merged 13 commits into
SkriptLang:master
from
bilektugrul:player-protocol-version
Apr 1, 2022
Merged
Add ExprPlayerProtocolVersion #4569
TPGamesNL
merged 13 commits into
SkriptLang:master
from
bilektugrul:player-protocol-version
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
requested changes
Feb 1, 2022
src/main/java/ch/njol/skript/expressions/ExprPlayerProtocolVersion.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
approved these changes
Feb 2, 2022
TPGamesNL
requested changes
Feb 3, 2022
src/main/java/ch/njol/skript/expressions/ExprProtocolVersion.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprPlayerProtocolVersion.java
Outdated
Show resolved
Hide resolved
TPGamesNL
approved these changes
Feb 10, 2022
Moderocky
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an expression for getting players' protocol version, exclusive to Paper. Supported all the way back to 1.12.
Also changed ExprProtocolVersion syntax. This can be a breaking change and open to discussion.
Target Minecraft Versions: any
Requirements: Paper
Related Issues: #1655