-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds back the JUnit testing system #4979
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! When #5299 is merged you can remove some duplicate code as TP said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 🚀
src/test/java/org/skriptlang/skript/test/tests/localization/UtilsPlurals.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Once TP's comments are addressed and his approval is obtained, this should be good to go.
…into feature/junit
Description
Adds back the JUnit testing system.
gradlew clean build
task.[the] [current[ly [running]]] junit test [name]
for test scripts to be able to figure out what JUnit test is being ran currently. This opens the possibility of anything to be done with Java to Skript for testing.gradlew clean
or noclean
if you don't want to clear the build cache. (Pickle and I wanted this in a conversation)Notes:
Related Issues: #4973