Improvements to EffAssert Logging

[sovdeeth]

Description

Adds the ability to provide expected and received values for an assertion that will be provided in the error message.

assert <.+> [(1:to fail)] with [error] %string%, expected [value] %object%, [and] (received|got) [value] %object%

For assertions using conditions that implement VerboseAssert (and that don't provide custom expected/got values), EffAssert will automatically grab expected/got messages from the condition itself. This will not work reliably for expressions that change between calls, like random expressions or ExprNow, as the assert effect calls getSingle/getAll a second time. For those scenarios, using a variable or a custom expected/got message is recommended.

So far, only CondCompare and CondIsSet implement VerboseAssert, but any condition that has significant use in tests is a valid target for implementation.

Suggestions are extremely welcome for a better interface name. This is the best kenzie and I could come up with in 5 minutes.

Example:

assert 1 is 2 with "failed number comparison" # sends "failed number comparison (Expected a value equal to 2, got 1)."
assert 1 is 2 or 3 with "failed number list comparison" # sends "failed number list comparison (Expected a value equal to 2 or 3, got 1)."

assert name of player is "tony" with "failed name check" # sends "failed name check (Expected a value equal to tony, got Sahvde)."

assert isNaN(difference between NaN value and NaN value) is true with "difference between NaN and NaN is not NaN", expected NaN value, got difference between NaN value and NaN value
# sends "difference between NaN and NaN is not NaN (Expected NaN value, got <number>)."

This PR also adds line numbers to the test error message:

- [ScriptName.sk]
+ [ScriptName.sk, line 24]

Todo:

• add expected/got value
• add line numbers
• clean up changes

---

Target Minecraft Versions: any
Requirements: none
Related Issues: none

[Moderocky]

Very welcome addition.

[AyhamAl-Ali]

Quality changes ⚡

[Moderocky]

I think I've fixed the conflicts on this but please just triple check it looks how you imagine it ought to!

[sovdeeth]

I think I've fixed the conflicts on this but please just triple check it looks how you imagine it ought to!

looks correct