Handle invalid regex pattern in ExprJoinSplit #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
added
the
bug
Efnilite
approved these changes
Nov 8, 2024
Co-authored-by: Efnilite <[email protected]>
sovdeeth
approved these changes
Nov 8, 2024
Romitou
approved these changes
Nov 10, 2024
Moderocky
approved these changes
Nov 12, 2024
Moderocky
added
the
patch-ready
APickledWalrus
approved these changes
Nov 20, 2024
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Dec 3, 2024
* handle invalid regex patterns * missing space in toString Co-authored-by: Efnilite <[email protected]> --------- Co-authored-by: Efnilite <[email protected]> Co-authored-by: sovdee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where an exception was thrown when compiling an invalid regex pattern. It also adds an error when an invalid regex pattern with a literal string. As well as optimizing splitting with a literal pattern by compiling and caching the pattern at initiation rather than with every evaluation.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7159