From 043d7470b80ceecc0ad1f64e05be22d5a01f7fbb Mon Sep 17 00:00:00 2001
From: Tyler Veness <calcmogul@gmail.com>
Date: Sun, 18 Feb 2024 16:28:57 -0800
Subject: [PATCH] Add default constructors to holonomic trajectory classes
 (#99)

---
 .../trajopt/trajectory/HolonomicTrajectory.h  | 18 ++++++++++--
 .../trajectory/HolonomicTrajectorySample.h    | 29 ++++++++++++-------
 src/trajectory/HolonomicTrajectory.cpp        | 26 -----------------
 src/trajectory/HolonomicTrajectorySample.cpp  | 20 -------------
 4 files changed, 35 insertions(+), 58 deletions(-)
 delete mode 100644 src/trajectory/HolonomicTrajectory.cpp
 delete mode 100644 src/trajectory/HolonomicTrajectorySample.cpp

diff --git a/include/trajopt/trajectory/HolonomicTrajectory.h b/include/trajopt/trajectory/HolonomicTrajectory.h
index 146c8a1b..0ab97d66 100644
--- a/include/trajopt/trajectory/HolonomicTrajectory.h
+++ b/include/trajopt/trajectory/HolonomicTrajectory.h
@@ -2,6 +2,7 @@
 
 #pragma once
 
+#include <utility>
 #include <vector>
 
 #include "trajopt/SymbolExports.h"
@@ -18,19 +19,32 @@ class TRAJOPT_DLLEXPORT HolonomicTrajectory {
   /// Trajectory samples.
   std::vector<HolonomicTrajectorySample> samples;
 
+  HolonomicTrajectory() = default;
+
   /**
    * Construct a HolonomicTrajectory from samples.
    *
    * @param samples The samples.
    */
-  explicit HolonomicTrajectory(std::vector<HolonomicTrajectorySample> samples);
+  explicit HolonomicTrajectory(std::vector<HolonomicTrajectorySample> samples)
+      : samples{std::move(samples)} {}
 
   /**
    * Construct a HolonomicTrajectory from a solution.
    *
    * @param solution The solution.
    */
-  explicit HolonomicTrajectory(const HolonomicSolution& solution);
+  explicit HolonomicTrajectory(const HolonomicSolution& solution) {
+    double ts = 0.0;
+    for (size_t samp = 0; samp < solution.x.size(); ++samp) {
+      if (samp != 0) {
+        ts += solution.dt[samp - 1];
+      }
+      samples.emplace_back(ts, solution.x[samp], solution.y[samp],
+                           solution.theta[samp], solution.vx[samp],
+                           solution.vy[samp], solution.omega[samp]);
+    }
+  }
 };
 
 }  // namespace trajopt
diff --git a/include/trajopt/trajectory/HolonomicTrajectorySample.h b/include/trajopt/trajectory/HolonomicTrajectorySample.h
index f9623a63..767cebeb 100644
--- a/include/trajopt/trajectory/HolonomicTrajectorySample.h
+++ b/include/trajopt/trajectory/HolonomicTrajectorySample.h
@@ -12,25 +12,27 @@ namespace trajopt {
 class TRAJOPT_DLLEXPORT HolonomicTrajectorySample {
  public:
   /// The timestamp.
-  double timestamp;
+  double timestamp = 0.0;
 
   /// The x coordinate.
-  double x;
+  double x = 0.0;
 
   /// The y coordinate.
-  double y;
+  double y = 0.0;
 
   /// The heading.
-  double heading;
+  double heading = 0.0;
 
   /// The velocity's x component.
-  double velocityX;
+  double velocityX = 0.0;
 
   /// The velocity's y component.
-  double velocityY;
+  double velocityY = 0.0;
 
   /// The angular velocity.
-  double angularVelocity;
+  double angularVelocity = 0.0;
+
+  constexpr HolonomicTrajectorySample() = default;
 
   /**
    * Construct a HolonomicTrajectorySample.
@@ -43,9 +45,16 @@ class TRAJOPT_DLLEXPORT HolonomicTrajectorySample {
    * @param velocityY The velocity's y component.
    * @param angularVelocity The angular velocity.
    */
-  HolonomicTrajectorySample(double timestamp, double x, double y,
-                            double heading, double velocityX, double velocityY,
-                            double angularVelocity);
+  constexpr HolonomicTrajectorySample(double timestamp, double x, double y,
+                                      double heading, double velocityX,
+                                      double velocityY, double angularVelocity)
+      : timestamp{timestamp},
+        x{x},
+        y{y},
+        heading{heading},
+        velocityX{velocityX},
+        velocityY{velocityY},
+        angularVelocity{angularVelocity} {}
 };
 
 }  // namespace trajopt
diff --git a/src/trajectory/HolonomicTrajectory.cpp b/src/trajectory/HolonomicTrajectory.cpp
deleted file mode 100644
index 731a8491..00000000
--- a/src/trajectory/HolonomicTrajectory.cpp
+++ /dev/null
@@ -1,26 +0,0 @@
-// Copyright (c) TrajoptLib contributors
-
-#include "trajopt/trajectory/HolonomicTrajectory.h"
-
-#include <memory>
-
-#include "trajopt/solution/HolonomicSolution.h"
-
-namespace trajopt {
-
-HolonomicTrajectory::HolonomicTrajectory(
-    std::vector<HolonomicTrajectorySample> samples)
-    : samples(std::move(samples)) {}
-
-HolonomicTrajectory::HolonomicTrajectory(const HolonomicSolution& solution) {
-  double ts = 0.0;
-  for (size_t samp = 0; samp < solution.x.size(); samp++) {
-    if (samp != 0) {
-      ts += solution.dt[samp - 1];
-    }
-    samples.emplace_back(ts, solution.x[samp], solution.y[samp],
-                         solution.theta[samp], solution.vx[samp],
-                         solution.vy[samp], solution.omega[samp]);
-  }
-}
-}  // namespace trajopt
diff --git a/src/trajectory/HolonomicTrajectorySample.cpp b/src/trajectory/HolonomicTrajectorySample.cpp
deleted file mode 100644
index d5ca9a11..00000000
--- a/src/trajectory/HolonomicTrajectorySample.cpp
+++ /dev/null
@@ -1,20 +0,0 @@
-// Copyright (c) TrajoptLib contributors
-
-#include "trajopt/trajectory/HolonomicTrajectorySample.h"
-
-namespace trajopt {
-
-HolonomicTrajectorySample::HolonomicTrajectorySample(double timestamp, double x,
-                                                     double y, double heading,
-                                                     double velocityX,
-                                                     double velocityY,
-                                                     double angularVelocity)
-    : timestamp(timestamp),
-      x(x),
-      y(y),
-      heading(heading),
-      velocityX(velocityX),
-      velocityY(velocityY),
-      angularVelocity(angularVelocity) {}
-
-}  // namespace trajopt