Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The VRServer is not gracefully shutdown #631

Closed
marcozzxx810 opened this issue Mar 14, 2023 · 2 comments
Closed

The VRServer is not gracefully shutdown #631

marcozzxx810 opened this issue Mar 14, 2023 · 2 comments
Labels
Area: Server Related to the server Priority: Normal The default priority Type: Bug Something isn't working

Comments

@marcozzxx810
Copy link
Contributor

How to reproduce:

  1. add a `logManager.info("hello") in https://github.com/SlimeVR/SlimeVR-Server/blob/main/server/src/main/java/dev/slimevr/VRServer.java#L179

  2. ./gradlew shadowJar

  3. put the slimevr.jar from SlimeVR-Server\server\build\libs to the your installation file

  4. The log doest has hello.

My proposal is that:

  1. Tauri should send sigterm to the server
  2. Then server should start the clean up process

Obstacle:

  1. now the server cannot handle SIGINT, need to investigate how to do so

Already tried to put a shutdown hook in the main function, but It still cannot work. Not sure it related to gradle

@marcozzxx810
Copy link
Contributor Author

marcozzxx810 commented Mar 14, 2023

This also create a problem of log lock is still there when the server close, but it should not have problem on user side

@ButterscotchV ButterscotchV added Type: Bug Something isn't working Priority: Normal The default priority Area: Server Related to the server labels Mar 22, 2023
@ImUrX
Copy link
Member

ImUrX commented Jul 26, 2023

This was fixed by #632

@ImUrX ImUrX closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Server Related to the server Priority: Normal The default priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants