From 9f551185070ad26e401541c64c6ecff87aa5702a Mon Sep 17 00:00:00 2001
From: Weiwu Zhang <a@colourful.land>
Date: Thu, 25 Jun 2020 20:55:52 +1000
Subject: [PATCH] allowing <source> element in activity cards, per tokenscript
 meeting #39

---
 ERCs/ERC20/ERC20-TokenScript.xml | 24 +++++++-----------------
 schema/tokenscript.xsd           |  3 ++-
 2 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/ERCs/ERC20/ERC20-TokenScript.xml b/ERCs/ERC20/ERC20-TokenScript.xml
index 1d384820..0d110edb 100644
--- a/ERCs/ERC20/ERC20-TokenScript.xml
+++ b/ERCs/ERC20/ERC20-TokenScript.xml
@@ -89,7 +89,7 @@
                     <ts:syntax>1.3.6.1.4.1.1466.115.121.1.36</ts:syntax>
                 </ts:type>
                 <ts:origins>
-                    <ethereum:event type="Approval" filter="${to}=${ownerAddress}" select="to"/>
+                    <ethereum:event type="Approval" filter="${to}=${ownerAddress}"/>
                 </ts:origins>
             </ts:attribute>
             <ts:item-view xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
@@ -103,22 +103,12 @@
         </ts:card>
 
         <ts:card type="activity" name="approvalObtained">
-            <ts:attribute name="amount">
-                <ts:type>
-                    <ts:syntax>1.3.6.1.4.1.1466.115.121.1.36</ts:syntax>
-                </ts:type>
-                <ts:origins>
-                    <ethereum:event type="Approval" filter="${to}=${ownerAddress}" select="amount"/>
-                </ts:origins>
-            </ts:attribute>
-            <ts:attribute name="from">
-                <ts:type>
-                    <ts:syntax>1.3.6.1.4.1.1466.115.121.1.36</ts:syntax>
-                </ts:type>
-                <ts:origins>
-                    <ethereum:event type="Approval" filter="${to}=${ownerAddress}" select="from"/>
-                </ts:origins>
-            </ts:attribute>
+          <!-- attributes like amount, from, to shouldn't need to be
+               defined here because they are implied -->
+            <ts:source>
+                <!-- contract="…" is missing, this might be a problem -->
+                <ethereum:event type="Approval" filter="${to}=${ownerAddress}" />
+            </ts:source>
             <ts:item-view xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
                 <style type="text/css">&style;</style>
                 <script  type="text/javascript">&item-view-approvalObtained.en;</script>
diff --git a/schema/tokenscript.xsd b/schema/tokenscript.xsd
index fd84ac70..f51a1e79 100644
--- a/schema/tokenscript.xsd
+++ b/schema/tokenscript.xsd
@@ -66,6 +66,7 @@
     <element name="card">
         <complexType>
             <sequence>
+                <element ref="asnx:module" minOccurs="0" maxOccurs="unbounded"/>
                 <element minOccurs="0" name="label" type="ts:text"/>
                 <element minOccurs="0" maxOccurs="unbounded" ref="ts:attribute"/>
                 <element minOccurs="0" maxOccurs="unbounded" ref="ts:selection"/>
@@ -253,7 +254,7 @@
                 </element>
                 <!-- label is not needed if the attribute is only used for selection -->
                 <element minOccurs="0" name="label" type="ts:text"/>
-                <element ref="ts:origins"/>
+                <element minOccurs="0" ref="ts:origins"/>
             </sequence>
             <attribute name="name" use="required" type="NCName"/>
             <attribute name="oid" type="NMTOKEN"/>