Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag sodium chloride as forge:salt? #47

Open
F8enjoyer opened this issue Feb 10, 2023 · 1 comment
Open

Tag sodium chloride as forge:salt? #47

F8enjoyer opened this issue Feb 10, 2023 · 1 comment

Comments

@F8enjoyer
Copy link

Would it be possible to add tag "forge:salt" to sodium chloride?
It would be great to allow some cooking ingredients to be synthesized and used with other mods.

I think the tag might make sense on the compound instead of the dust, to give appropriate ratios.
(For comparison, minecraft sugar seems to have a 1:1 ratio with the sucrose compound, not the sucrose dust)

It could also be nice to add dissolver recipes for the salt items from mods like mekanism and croptopia, but perhaps that is a separate issue.

Implementation ideas?

I'm new to the codebase, but it looks like ItemTagGenerator.java could be a place to do it?
(OTOH, there appears to be a pattern developing, so perhaps adding support for tags in ChemicalRegistry.java and compounds.json is the way to go?)

I imagine there could also be a fabric equivalent, but I haven't looked there yet.

Thanks!

@F8enjoyer
Copy link
Author

(Obligatory Ex&F video: https://www.youtube.com/watch?v=RJh9yTIBY48 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant