Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic_WebSkeletonApp example is missing bootstrap and jquery resources #90

Open
robotiko opened this issue Mar 12, 2016 · 4 comments
Open

Comments

@robotiko
Copy link

Missing bootstrap and jquery resources

@hreintke
Copy link
Collaborator

@avr39-ripe

I looked once more and now in detail to your webskeleton example and see the following as possible enhancements.

  • update the use of static buffer and staticjsonbuffer to dynamic
  • Rename all items which have "therm" in it to a more generic term
  • Make the name of the configfile adaptable with an environment variable
  • Make the loadconfig and saveconfig class functions
  • Rename the configuration.cpp to therm.cpp -> ClassName.h & ClassName.cpp are accepted standards
  • Instantiate the ActiveConfig within the application -> keep the class definition separated form instantiation
  • Check for valid configuration data from config file within loadconfig()
  • The rename the webserver.cpp as the "application logic" is mainly that
  • Clarify the process within onConfiguration.
  • the root.prettyprint goes to serial (cannot switch off)
  • test complete for valid json input, not only stassid
  • split between "setting/saving" config and activating config
  • Can I get the stassid/paswsword by just knowing the right url ?
  • Make real use of the new WifiEvents and wait for network before starting servers etc
  • Not sure but what is the behavior of the application when the initial ssid/pwd just not connect ?

@hreintke
Copy link
Collaborator

@avr39-ripe :
Will add to this issue when I see/more other if that is OK.

  • Updated the SPIFF_SIZE = 196608 to a value which is actually needed to prevent long during flashes
  • What is the rationale for these settings ?
    //SET higher CPU freq & disable wifi sleep
    system_update_cpu_freq(SYS_CPU_160MHZ);
    wifi_set_sleep_type(NONE_SLEEP_T);

@avr39-ripe
Copy link
Contributor

@hreintke YES! indeed!!! anybody is welcome to comment this app and suggest better aproaches, or just rise issues.. thank you very much for good critic!!

@avr39-ripe
Copy link
Contributor

//SET higher CPU freq & disable wifi sleep
system_update_cpu_freq(SYS_CPU_160MHZ);
wifi_set_sleep_type(NONE_SLEEP_T);

faster CPU :) less time to do things, second is more doubtfull, found somewhere as to enhance wifi stability.. will remove it as unconfirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants