output: store a weak ref in the global to avoid... #1589
Conversation
...a cycle keeping the output alive indefinitely
cmeissl
force-pushed
the
fix/output_data_cycle
branch
from
9697477 to
b321581
Compare
|
@ids1024 With this the check seems to work as expected in anvil (not saying we shouldn't think about an alternative) |
|
Ah. So when does global user data like this actually get freed? Only once every client that has had a registry with the global present has disconnected? |
|
|
||
| let Some(output) = global_data.output.upgrade() else { | ||
| tracing::warn!("trying to bind a destroyed output, forgot to disable a output global?"); | ||
| return; |
There was a problem hiding this comment.
I don't think we should and can just return here. Any request to the output would otherwise trigger a panic, given we didn't initialize it's data.
The warning is fine (and a good idea), but I think we should just initialize the OutputUserData with Weak::new.
The global data itself is freed on |
|
Yeah, as long as this is freed immediately when |
...a cycle keeping the output alive indefinitely
Should get rid of the last cycle in smithay as mentionen in #1585 and hopefully fix #1584