deduplicate models bounding box computation #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically BufferGeometry.computeBoundingBox, which sets
BufferGeometry.boundingBox
, looks like it is not used anywhere.The code uses computeLocalBoundingBox, using more or less the same algorithm but with additional tree traversal and matrix composition logic.
fwiw, each of those can take up to 100ms to compute on large-ish models so it can add up quickly. Ideally i'd totally skip this if the box can be retrived from the svx document or at least compute only the Thumb model's box and roll with it, but that'd be a more substantial change for another time.