You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As observed by @ekuiter and me as part of PR #109, some attributes sometimes have brackets for their entries and sometimes they don't (i.e., numpages = 10 vs. numpages = {10}). Affected attributes are at least numpages, volume, number, and year.
To fix this issue:
Determine if there are other number-type attributes that might be affected.
For each attribute decide on whether to keep or avoid brackets, such as numpages = 10 or numpages = {10}. Maybe avoid brackets for all of them, as we do for year? Can something else appear within these attributes that is not a number? At least for number I know that it might carry something else (e.g., number = {OOPSLA2} for BSM+:OOPSLA24). Here, not using brackets could falsely lead to OOPSLA2 being interpreted as a variable, in case such a variable is defined. This might lead to undesired, silent bugs for nun-numeric values. So maybe avoid brackets only for numeric values?
year: no brackets (this is mostly consistent throughout literature.bib)
numpages: ?
volume: ?
number: ?
Enforce consistent style, best with an automated solution. @skrieter Do you think we could implement this as part of your CI pipeline? In best case, we
can find inconsistencies in the CI pipeline
have a script to automatically fix the styles for the whole literature.bib in a big-bang fix.
Maybe all of this is too overengineered anyway....
The text was updated successfully, but these errors were encountered:
As observed by @ekuiter and me as part of PR #109, some attributes sometimes have brackets for their entries and sometimes they don't (i.e.,
numpages = 10
vs.numpages = {10}
). Affected attributes are at leastnumpages
,volume
,number
, andyear
.To fix this issue:
numpages = 10
ornumpages = {10}
. Maybe avoid brackets for all of them, as we do foryear
? Can something else appear within these attributes that is not a number? At least fornumber
I know that it might carry something else (e.g.,number = {OOPSLA2}
forBSM+:OOPSLA24
). Here, not using brackets could falsely lead to OOPSLA2 being interpreted as a variable, in case such a variable is defined. This might lead to undesired, silent bugs for nun-numeric values. So maybe avoid brackets only for numeric values?year
: no brackets (this is mostly consistent throughoutliterature.bib
)numpages
: ?volume
: ?number
: ?literature.bib
in a big-bang fix.The text was updated successfully, but these errors were encountered: