Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project should use bom internally #1

Open
snicoll opened this issue Feb 9, 2020 · 0 comments
Open

Project should use bom internally #1

snicoll opened this issue Feb 9, 2020 · 0 comments

Comments

@snicoll
Copy link

snicoll commented Feb 9, 2020

The current structure is designed in such a way that the bom is a module like any other modules of this project. This defeats the purpose of testing dependency management internally and separating what is public and what isn't.

The content in its parent (solace-spring-boot-build)has a number of internal/project specific choices that the bom should not know about. The flatten maven plugin is used to publish a "cleaned" bom. That's a great idea but that doesn't shield you from something that may work here and fail in user's project.

A better arrangement would be to move everything build related from -build to -parent and make -parent inherit from the bom. The Spring Initializr project is a concrete example of such arrangement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant