Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How handle a different label for Solace #47

Open
murillocg opened this issue Sep 15, 2022 · 2 comments
Open

How handle a different label for Solace #47

murillocg opened this issue Sep 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@murillocg
Copy link

Hello,

I'm unsure if this is the right place to ask this question. If not, please let me know the right one.

At my company, we've been using the Cloundfoundry as PaaS, but the Solace service name is not solace-pubsub, so the library solace-java-cfenv does not work for me https://github.com/SolaceProducts/solace-spring-boot/tree/master/solace-java-cfenv.

I'm using this dependency in our Spring Boot applications, but it's not able to instantiate the SolaceJavaProperties and I need to do so on my side because of this issue.

<dependency>
	<groupId>com.solace.spring.boot</groupId>
	<artifactId>solace-java-spring-boot-starter</artifactId>
</dependency>

Best Regards

@Nephery Nephery added the enhancement New feature or request label Sep 16, 2022
@Nephery
Copy link
Collaborator

Nephery commented Sep 16, 2022

Right now, solace-java-cfenv finds its services by looking for a solace-pubsub label or a solace-pubsub tag.

Sounds like we need to make the service lookup label (and maybe tag) configurable and expose that to Spring Boot auto-configuration. Maybe we can call them something like solace.cloudfoundry.service-lookup.label and solace.cloudfoundry.service-lookup.tag.

@murillocg
Copy link
Author

murillocg commented Sep 22, 2022

It is worth mentioning that, beyond the service name, the properties are different as well. You can see it in our workaround using the application.properties here:

# Solace Properties
solace.java.host=${vcap.services.message-queuing.credentials.smf.url}
solace.java.msgVpn=${vcap.services.message-queuing.credentials.brokerName}
solace.java.clientUsername=${vcap.services.message-queuing.credentials.smf.auth.basic.userName}
solace.java.clientPassword=${vcap.services.message-queuing.credentials.smf.auth.basic.password}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants