Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder doesn't respect a kill request until retries exhausted #26

Open
Mrc0113 opened this issue Sep 2, 2020 · 2 comments
Open

Binder doesn't respect a kill request until retries exhausted #26

Mrc0113 opened this issue Sep 2, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Mrc0113
Copy link
Contributor

Mrc0113 commented Sep 2, 2020

The solace cloud stream binder doesn't seem to respect a kill request prior to being connected. This is not ideal when developing in an IDE (This happens in eclipse and spring tool suite. Have not verified with Intellij or others). If you use the wrong credentials you can't hit the stop button until your retries are exhausted which can take quite some time since I think the default per host is 21.

To reproduce:
Set the following properties and include an invalid password. Start your app via your IDE and watch it fail to connect forever even after you try to stop it

spring.cloud.stream.binders.solace.environment.solace.java.connectRetries=-1
spring.cloud.stream.binders.solace.environment.solace.java.connectRetriesPerHost=-1
@Nephery Nephery added the bug Something isn't working label Sep 3, 2020
@Mrc0113
Copy link
Contributor Author

Mrc0113 commented Oct 30, 2020

More info on this. The issue isn't not responding to a traditional kill request. A traditional kill request such as "ctrl+c" or killing it when running as a "java application" in eclipse work. However, the app doesn't respect a "inMXBeanRegistrar$SpringApplicationAdmin : Application shutdown requested." which is what Spring Tool Suite issues when you stop a Spring Boot app (started using "Run as" -> "Spring Boot App" and I believe is the proper request to shutdown Spring Boot apps.

I have not yet had the chance to verify if this is a framework issue or a binder issue by trying with a different binder.

@PhilippeKhalife
Copy link
Contributor

Leaving in current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants