Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidOS should not silently fail when unable to retrieve WebID during granting permission #209

Open
renyuneyun opened this issue Jun 26, 2024 · 1 comment

Comments

@renyuneyun
Copy link

renyuneyun commented Jun 26, 2024

SolidOS/Mashlib has a tab for each resource/container to modify its sharing permissions / access control lists. It allows to grant permission to an individual WebID entered by the user.
If everything goes normal, after entering WebID and clicking yes, the textbox and yes/no disappears, and an avatar corresponding to that WebID will appear as a "viewer". Then the user can drag-and-drop it to the appropriate location.

However, if the entered WebID cannot be retrieved, the textbox and yes/no disappears as well, but nothing further happens. This is very un-user-friendly...

Preferably, SolidOS should either:

  1. Alarm the user that something wrong happened when retrieving the WebID document; or
  2. Add the WebID as a viewer regardlessly; or
  3. A combination of the two above (e.g. alarm, and allow proceeding regardlessly).

I haven't tried similar things on other types, but maybe worth checking if they have similar issues?

@melvincarvalho
Copy link
Contributor

Good feedback, I lean towards (2)—adding the WebID even if SolidOS can't connect.

The Pod might be down, or the client could have lost internet. In a local-first model, SolidOS should be able to function offline, like during a plane flight.

There's definitely scope to enhance the UX with warnings as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants