Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain trust information not working #614

Closed
matt-moses opened this issue Nov 16, 2022 · 10 comments
Closed

Domain trust information not working #614

matt-moses opened this issue Nov 16, 2022 · 10 comments
Labels

Comments

@matt-moses
Copy link

matt-moses commented Nov 16, 2022

Describe the bug
Domain trust information is getting lost somewhere either in ingestion or failing to map on the UI. I have verified that SharpHound is collecting the domain trust information by reviewing the SharpHound JSON (see screenshots). After importing the SharpHound JSON files domain trust is not viewable.

To Reproduce
Steps to reproduce the behavior:

  1. In a domain that holds trust in another domain, run SharpHound (1.1.0).
  2. Import the SharpHound zip.
  3. Using the BloodHound (4.2.0) menu option to "show domain trusts"

Expected behavior
Domain trusts are mapped onto the screen.

Screenshots
This screenshot is to verify that the trust information exists in the JSON.
2022-11-12-075423_002

2022-11-12-075825_002

2022-11-12-075513_002

@matt-moses matt-moses added the bug label Nov 16, 2022
@matt-moses
Copy link
Author

@matt-moses
Copy link
Author

Reviewing the code and I'm definitely new here but wanted to throw out this lead...could it be related to the changes regarding moving from oldingestion.js to newingestion.js? Looks like the JSON produced from the latest SharpHound uses integers but the newingestion.js has moved to strings for denoting things like TrustDirection and TrustType which would cause these conditions to be unmet: https://github.com/BloodHoundAD/BloodHound/blob/master/src/js/newingestion.js#L795

See also https://github.com/BloodHoundAD/BloodHound/blob/master/src/js/newingestion.js#L3

@matt-moses
Copy link
Author

Suggested work around:

image

@dadevel
Copy link

dadevel commented Jan 26, 2023

I stumbled upon the issue today and automated the workaround in a small Python script: https://gist.github.com/dadevel/a8e7f5af88f659e99141e21011b1f37d
Maybe its helpful to someone.

FYI: There's also an related issue open in SpecterOps/SharpHound#33

@Pastea
Copy link

Pastea commented Apr 7, 2023

I stumbled upon the issue today and automated the workaround in a small Python script: https://gist.github.com/dadevel/a8e7f5af88f659e99141e21011b1f37d Maybe its helpful to someone.

FYI: There's also an related issue open in BloodHoundAD/SharpHound#33

There is a typo on line 71, array should be TRUST_TYPES, not TRUST_DIRECTIONS

@dadevel
Copy link

dadevel commented Apr 7, 2023

@Pastea Thanks, I fixed it.

@JonasBK
Copy link
Contributor

JonasBK commented Apr 27, 2023

Hi @matt-moses,

Thanks for reporting the issue.

I think someone changed SharpHoundCommon without updating BloodHound 🙃
It will be fixed with this commit: 7d3c0fb

I will close this issue when 4.3.1 is released.

@rvazarkar
Copy link
Contributor

Should be fixed in 4.3.1

@rvazarkar rvazarkar reopened this May 8, 2023
@matt-moses
Copy link
Author

Thanks all!

@JonasBK
Copy link
Contributor

JonasBK commented May 24, 2023

Closing - Fixed in 4.3.1 🥳

@JonasBK JonasBK closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants