Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare domain object attributes for ADCS ESC6 #94

Merged

Conversation

definitelynotagoblin
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 10, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@definitelynotagoblin
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rvazarkar
Copy link
Contributor

rvazarkar commented Jan 11, 2024

IsDC and DomainSID will need to be elevated to a new property on the Computer model as well

Copy link
Contributor

@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using HasFlag feels more intuitive to me so I appreciate the change. Thanks for updating the tests!

@definitelynotagoblin definitelynotagoblin merged commit 79a9b84 into SpecterOps:v3 Jan 19, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants