Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion on primary color #202

Open
zemian opened this issue Aug 24, 2023 · 3 comments
Open

Suggestion on primary color #202

zemian opened this issue Aug 24, 2023 · 3 comments
Labels

Comments

@zemian
Copy link

zemian commented Aug 24, 2023

Hi Stanley, I know I have opened many issues recently in trying out your CSS library. I just want to say that I found Cirrus CSS very useful and well done, so thank you so much for providing this nice CSS library!

Anyrate, a suggestion on the Primary color (https://cirrus-ui.netlify.app/fundamentals/colors). It's currently set to #f03d4d, which is RED color. Now I don't have issue with "red" per se, but it is a very common color for error or to indicate something is wrong. (which you do have "danger" color name representing that already, which is awesome.) But as a default Cirrus CSS choice to use RED again as primary is a bit much and confusing to users. It's more practical and useful to many projects not to use RED as primary color.

I understand this is a personal taste, and there will be projects that choose to use that as their color scheme, which is fine. But as a general CSS utility, perhaps it can help users to setup a more general use cases before selecting "RED" as primary color. Just my humble opinion. :)

Keep up the great work!

@Spiderpig86
Copy link
Owner

Hey @zemian! I actually welcome all the issues since it will only help to make Cirrus better. :)
I will get to the other open ones when I have some more time soon.

As for configuring the primary color, you can modify it and more inside the configuration file. This will require you to build your own version of Cirrus within your project (e.g. make the changes, transpile, and copy over the artifacts or import the framework directly). I have a guide here that should help with getting that started. There is also another section about different setups here.

Please let me know if you have any more questions!

@zemian
Copy link
Author

zemian commented Aug 24, 2023

I understand we can make custom built to change it. My point is the default value of primary color should be more general, so we don't have to go custom build just to avoid RED as primary color, which often compete with the meaning of danger.

@BAProductions
Copy link

or why no just make it a css var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants