Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding modal-large to modal didn't work #205

Open
zemian opened this issue Aug 27, 2023 · 4 comments
Open

Adding modal-large to modal didn't work #205

zemian opened this issue Aug 27, 2023 · 4 comments

Comments

@zemian
Copy link

zemian commented Aug 27, 2023

I tried it here: https://codepen.io/zemian/pen/OJrMNPe and it has no affect. Did I do something wrong?

@Spiderpig86
Copy link
Owner

For modals, the modal-large and modal-small classes only affect the max-width of the modal, not width itself. If you want to set the width, consider using the width utility classes. https://www.cirrus-ui.com/layout/width#width

@zemian
Copy link
Author

zemian commented Aug 28, 2023

Then I failed to see the purpose (usefulness) of modal-large class.

Also, the docs says add modal-large to modal, but if I were to use the utility class such as w-80p, I have to add to modal-content in order to work.

This is just too much guess work for a user to simply want a larger dialog box. Can this be improved?

@Spiderpig86
Copy link
Owner

This will have to be re-done in terms of naming, but that would be a breaking change. I agree that it is confusing since modal encompasses everything (the dialog itself and the background shadow) while modal-content is the dialog itself. Ideally, these should be renamed as modal-container and modal respectively.

I will make a decision to see if there is quite a big risk for this breaking change.

@Spiderpig86
Copy link
Owner

Addressed renaming with 9da499f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants