Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] latest version not remembering window position #272

Open
Incognito-100 opened this issue Dec 3, 2024 · 6 comments
Open

[Bug] latest version not remembering window position #272

Incognito-100 opened this issue Dec 3, 2024 · 6 comments
Labels
bug Something isn't working upstream A bug or feature that must be implemented elsewhere

Comments

@Incognito-100
Copy link

Describe the bug
new update doesn't remember window size and position

To Reproduce
Steps to reproduce the behavior: open apps resize or move it then close it down and reopen

System Info (please complete the following information):

  • OS: Windows 11
  • Version: 6.3.0
  • Extra Client Mods/Plugins: None
@Incognito-100 Incognito-100 added the bug Something isn't working label Dec 3, 2024
@SpikeHD
Copy link
Owner

SpikeHD commented Dec 3, 2024

Does it work with v6.2.0?

@kajoken
Copy link

kajoken commented Dec 3, 2024

Came here to say the same. After the update to 6.3.0 that old bug is back. Worst thing is, I can't downgrade to 6.2.0 since it forces the update on us. 6.2.0 worked fine, now it's back to it's little starting window every time.

@SpikeHD
Copy link
Owner

SpikeHD commented Dec 3, 2024

It only forces the update on you only if you have autoupdate enabled, if it's a problem you can disable it on v6.3.0 before going back to v6.2.0

As for root cause, I honestly couldn't find it at a glance, I moved some old code around but there is still the saving and restoration of window state, at roughly the same spot in the load/window destroy cycle they always were. I'll do some testing and maybe rollback the window state plugin if I have to

@kajoken
Copy link

kajoken commented Dec 3, 2024

Thanks for the heads up. I totally forgot I had auto update active. Deactivated, went back to 6.2.0 and it works fine again.

@SpikeHD
Copy link
Owner

SpikeHD commented Dec 3, 2024

Looks like this is caused by a regression in one of the libraries Dorion uses (see tauri-apps/tauri#11740), that comes from having both decorations off and window shadows enabled, which is mighty unlucky since Dorion does in fact do both, lol.

Once tao is updated (see tauri-apps/tao#1010) and tauri is updated to use that new version , I will release a patch 👍

For now, if it helps, Dorion will still remember if it were maximized and will re-maximize itself, it just won't properly apply size and position. This is also only a Windows issue, and worked fine on my M1 Macbook when testing.

@SpikeHD SpikeHD added the upstream A bug or feature that must be implemented elsewhere label Dec 3, 2024
@Incognito-100
Copy link
Author

good to know the fix seem easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream A bug or feature that must be implemented elsewhere
Projects
None yet
Development

No branches or pull requests

3 participants