Proposed Refactor for Heartbeat Resources

[theladyjaye]

What do you think about making the Heartbeat stuff USE another SwiftyHue API as opposed to right now it's all locked together.

For example, Heartbeat should could call a function to give it it's requested resources, in that way other clients could call the same thing if they didn't want to use the heartbeat.

Example implementation:

    public func fetch<Error: Swift.Error, Resource: BridgeResource & BridgeResourceDictGenerator where Resource.AssociatedBridgeResourceType == Resource>(resource: HeartbeatBridgeResourceType, callback:(Result<[String: Resource], Error>) -> ()){

        guard let authorization = _authorization else {
            log.error("No 'Authorization' set'")
            return
        }

        let url = "http://\(authorization.ipAddress)/api/\(authorization.username)/\(resource.rawValue.lowercased())"

        Alamofire.request(.GET, url)
            .responseJSON { response in

                switch response.result {
                case .success(let data):

                    let resources = Resource.dictionaryFromResourcesJSON(data as! JSON)
                    let result = Result<[String: Resource], Error>.success(resources)
                    callback(result)

                case .failure(let error):
                    let result = Result<[String: Resource], Error>.failure(error as! Error)
                    callback(result)
                }
        }
    }


    public func fetchLights(_ callback: (Result<[String: Light], NSError>) -> ()){
        fetch(resource: .lights, callback: callback)
    }

call site example:

something.fetchLights{
    (result) in
            switch result {
            case .success(let lights):
                print(lights)

            case .failure(let error):
                print(error)
            }
        }

Now heartbeat could call it on an interval, or anything else could just call it once.

Keeping with what is there, since a SendAPI exists, it would be introducing a ResourceAPI

[Spriter]

Not a bad idea. We have also discussed this before. We will discuss this again.

[SamwiseChepoackra]

Do you have any plans to release in swift 4?

Also are there any resources on implanting groups in swift?

Thanks for your work here