Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile fixmes #111

Open
cdlm opened this issue Sep 2, 2016 · 1 comment
Open

Makefile fixmes #111

cdlm opened this issue Sep 2, 2016 · 1 comment
Assignees
@cdlm

Comments

@cdlm
Copy link
Member

cdlm commented Sep 2, 2016 •
edited
Loading

Style :

  • cp -r should be cp -R
  • phony targets should be declared
  • copySupport.mk being a separate file makes little sense

User-friendlyness :

  • a sensible default target should be defined
  • presence of dependencies fetched by subdownload.sh should be checked by the makefile
  • should run ./gitinfo2.sh >> book-result/gitHeadLocal.gin before building the book
@cdlm cdlm self-assigned this Sep 2, 2016
This was referenced Sep 9, 2016
Open
Closed
@cdlm
Copy link
Member Author

cdlm commented Sep 9, 2016

Superseded by pillar-markup/Pillar-Archetype#2; will require backporting the fixes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdlm cdlm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdlm