Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollout_buffer_class to TRPO #214

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

ernestum
Copy link
Contributor

Description

This adds the rollout_buffer_class to TRPO in sync with DLR-RM/stable-baselines3#1720. I decided not to add it to MaskeablePPO and RecurrentPPO since they require special rollout buffers.

Context

  • I have raised an issue to propose this change (required)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • The functionality/performance matches that of the source (required for new training algorithms or training-related features).
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have included an example of using the feature (required for new features).
  • I have included baseline results (required for new training algorithms or training-related features).
  • I have updated the documentation accordingly.
  • I have updated the changelog accordingly (required).
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin
Copy link
Member

araffin commented Oct 30, 2023

Fyi, I already did a pre-release https://pypi.org/project/stable-baselines3/2.2.0a9/, and you would need it to build this SB3 contrib version ;)

@ernestum
Copy link
Contributor Author

Oh nice thanks!

@araffin araffin merged commit b5e6518 into master Oct 30, 2023
4 checks passed
@araffin araffin deleted the add_rollout_buffer_class_to_on_policy_algos branch October 30, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants