Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect atttribute of Crossspectrum used to calculate time lag in Simulator.ipynb tutorial #61

Open
bjricketts opened this issue Nov 3, 2022 · 1 comment

Comments

@bjricketts
Copy link

On line 600, the .cs attribute is used instead of .power to calculate the time lag.
e.g. It should be:
lag = np.angle(cross.power)/ (2 * np.pi * cross.freq)
instead of:
lag = np.angle(cross.cs)/ (2 * np.pi * cross.freq)
as it currently is.

@matteobachetti
Copy link
Member

@bjrickets thank you so much for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants