You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recently reported bug showed that people were using the fdot keyword in fold_events. This keyword does not exist, but the function is accepting it and ignoring it due to the use of **kwargs. Using such a name for this keyword is understandable, as it's used in other functions, and not having an error people assume it's correct.
Your suggestions for the Fix
I suggest adding a check and a warning, or even a ValueError, for ignored keywords.
The text was updated successfully, but these errors were encountered:
Hi,
I have written a fix for this, PR #837. I noticed that fdot is a parameter, although it does not need a keyword to be passed.
The description of the function mentions this, but it might not be clear to the user.
Description of the Issue
A recently reported bug showed that people were using the
fdot
keyword infold_events
. This keyword does not exist, but the function is accepting it and ignoring it due to the use of**kwargs
. Using such a name for this keyword is understandable, as it's used in other functions, and not having an error people assume it's correct.Your suggestions for the Fix
I suggest adding a check and a warning, or even a
ValueError
, for ignored keywords.The text was updated successfully, but these errors were encountered: