Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework exported type names in @frogpond/filter #6435

Open
drewvolz opened this issue Sep 25, 2022 · 0 comments
Open

Rework exported type names in @frogpond/filter #6435

drewvolz opened this issue Sep 25, 2022 · 0 comments

Comments

@drewvolz
Copy link
Member

Originally posted by @rye in #6413 (comment)

The type of filters (ListType) doesn't make sense to me when I am reading this. What is that? Are we filtering lists? Can "lists" be passed as filters? I feel like this is an upstream issue with @frogpond/filter, so we can ignore that, but that's why I was confused by this code.

(Also the Type suffix should get dropped from types as a general rule. Types are types, yes. And a more TypeScript-y way would have us make these full-fledged interfaces, I think, but that's a wide-scale change.)

Reply posted by @hawkrives in #6413 (comment)

I want to say that back in Flow, there wasn't as much separation between the "type namespace" and "value namespace", so I tended to suffix things with Type$. This is my fault for bad API design. We should fix it upstream, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant