Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Well-formed commit messages? #2

Open
3 tasks
hawkrives opened this issue Aug 2, 2016 · 7 comments
Open
3 tasks

Well-formed commit messages? #2

hawkrives opened this issue Aug 2, 2016 · 7 comments

Comments

@hawkrives
Copy link
Member

hawkrives commented Aug 2, 2016

Do we need/want some sort of commit message requirement?

If not:

  • how do we make sure to check all submitted assignments?
  • What if they complete several in one push?
  • How do they tell us that they re-submitted an assignment?
@OmarShehata
Copy link
Contributor

What if we had them under the assignment number in the commit message? So a commit of hw2 would just run all homework 2 checks. So even if you're only submitting part of it, it'll tell you, you're missing X,Y and Z, but W is complete, so you are 30% complete.

And they can resubmit as much as they want by just committing with that message.

@hawkrives
Copy link
Member Author

So you just always include a hw# / lab# in your commit message, and it will run a check?

@hawkrives
Copy link
Member Author

In the case of multiple commits being pushed, we should probably filter out any duplicates so that we only check the latest versions of each assignment

@OmarShehata
Copy link
Contributor

That sounds like the most straightforward to me. So the student knows what checks will run, and she knows it's all good when the commit message comes back as "100% complete!".

@hawkrives
Copy link
Member Author

Something else to keep in mind: we're going to need some way of automatically updating the specs / checkers on the gitlab machine

@OmarShehata
Copy link
Contributor

More webhooks! We can have it automatically pull down and run whatever script whenever someone pushes to the Referee repo. That's what I did for the HiPerCiC documentation, where it pulls and runs a script to convert the reStructured markup into html.

@hawkrives
Copy link
Member Author

Great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants