366 new attrs for osfi reports bd and bb #369
Merged
+49
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emburkino did we add these to the JSON schema as well? |
emburkino
force-pushed
the
366-new-attrs-for-osfi-reports-bd-and-bb
branch
from
21b62cc to
1055823
Compare
Updated now |
|
Hey @emburkino we don't want to add more exceptions to the schemas tests, can you change the economic_loss enums to econ_loss... so they are shorter and we don't have to modify the tests Thanks |
added 7 commits
December 13, 2024 10:50
emburkino
force-pushed
the
366-new-attrs-for-osfi-reports-bd-and-bb
branch
from
9ff87af to
ba4c7f6
Compare
|
great @emburkino and extra points for sorting the enums in the documentation (+1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attributes on the Loan and Account schemas to accommodate for the OSFI data requirement for reports BB and BD
Attributes as follows: