From 3de3149e1502054f56d7062ea619464db62a60fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miko=C5=82aj=20=C5=9Awi=C4=85tek?= Date: Wed, 20 Sep 2023 16:36:20 +0200 Subject: [PATCH] fix(metrics): decompose OTLP histograms Sumo doesn't support OTLP Histograms natively yet. Enable decomposing these histograms into Gauge metrics in the exporter. (cherry picked from commit d71a1da5634385c77f39a5dfccb9ce37bddf2d81) --- .changelog/3289.fixed.txt | 1 + deploy/helm/sumologic/conf/metrics/otelcol/exporters.yaml | 2 ++ .../metadata_metrics_otc/additional_endpoints.output.yaml | 1 + .../testdata/goldenfile/metadata_metrics_otc/basic.output.yaml | 1 + .../testdata/goldenfile/metadata_metrics_otc/custom.output.yaml | 1 + 5 files changed, 6 insertions(+) create mode 100644 .changelog/3289.fixed.txt diff --git a/.changelog/3289.fixed.txt b/.changelog/3289.fixed.txt new file mode 100644 index 0000000000..86b6815001 --- /dev/null +++ b/.changelog/3289.fixed.txt @@ -0,0 +1 @@ +fix(metrics): decompose OTLP histograms \ No newline at end of file diff --git a/deploy/helm/sumologic/conf/metrics/otelcol/exporters.yaml b/deploy/helm/sumologic/conf/metrics/otelcol/exporters.yaml index e2dfda95fa..f5751c000c 100644 --- a/deploy/helm/sumologic/conf/metrics/otelcol/exporters.yaml +++ b/deploy/helm/sumologic/conf/metrics/otelcol/exporters.yaml @@ -3,6 +3,8 @@ sumologic/default: metric_format: {{ include "metrics.otelcol.exporter.format" . }} endpoint: {{ include "metrics.otelcol.exporter.endpoint" . }} + ## Sumo doesn't yet natively support OTLP Histograms + decompose_otlp_histograms: true ## Configuration for sending queue ## ref: https://github.com/open-telemetry/opentelemetry-collector/tree/release/v0.37.x/exporter/exporterhelper#configuration sending_queue: diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/additional_endpoints.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/additional_endpoints.output.yaml index d835fca4fe..8c594a77d7 100644 --- a/tests/helm/testdata/goldenfile/metadata_metrics_otc/additional_endpoints.output.yaml +++ b/tests/helm/testdata/goldenfile/metadata_metrics_otc/additional_endpoints.output.yaml @@ -44,6 +44,7 @@ data: storage: file_storage timeout: 30s sumologic/default: + decompose_otlp_histograms: true endpoint: ${SUMO_ENDPOINT_DEFAULT_METRICS_SOURCE} max_request_body_size: 16777216 metric_format: prometheus diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/basic.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/basic.output.yaml index 388a7323c0..3e7cd6c486 100644 --- a/tests/helm/testdata/goldenfile/metadata_metrics_otc/basic.output.yaml +++ b/tests/helm/testdata/goldenfile/metadata_metrics_otc/basic.output.yaml @@ -44,6 +44,7 @@ data: storage: file_storage timeout: 30s sumologic/default: + decompose_otlp_histograms: true endpoint: ${SUMO_ENDPOINT_DEFAULT_METRICS_SOURCE} max_request_body_size: 16777216 metric_format: prometheus diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/custom.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/custom.output.yaml index 69c63e68f8..8b9728b12f 100644 --- a/tests/helm/testdata/goldenfile/metadata_metrics_otc/custom.output.yaml +++ b/tests/helm/testdata/goldenfile/metadata_metrics_otc/custom.output.yaml @@ -14,6 +14,7 @@ data: config.yaml: | exporters: sumologic/default: + decompose_otlp_histograms: true endpoint: ${SUMO_ENDPOINT_DEFAULT_OTLP_METRICS_SOURCE} max_request_body_size: 16777216 metric_format: otlp