Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting known types? #4

Open
Scalpel78 opened this issue Oct 17, 2018 · 2 comments
Open

Syntax highlighting known types? #4

Scalpel78 opened this issue Oct 17, 2018 · 2 comments

Comments

@Scalpel78
Copy link
Contributor

It would be nice if known types, like String, Integer, etc was highlighted in a separate color.

This is a screenshot from C# in Visual Studio:
image

This is CRMScript in VS.Code:
image

I wish VS.Code had syntax highlighting on the types.

@Scalpel78
Copy link
Contributor Author

Added 'class.type.crmscript', and punched in a few of the classes. They are now identified by the "Developer: Inspect TM scopes" command, and have a separate color:

image

If this is the correct way of doing things, then we need to add more classes in the pattern. If I've misunderstood how this works, then feel free to remove it again.

@ejfasting
Copy link
Member

This is the correct approach if we are to have it on the client side. An alternative would be to return Sematic Highlighting Tokens from the server that the client can use.
This would probably be a better approach as we can dynamically return sematic tokens depending on what the intellisense contains, instead of hardcoding it into the .tmLanguage-file.

Moving logic into the server would also make it easier to implement support for other editors as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants